Skip to content

Commit e11b008

Browse files
author
R. Tyler Croy
authored
Merge pull request #318 from rtyler/new-jrub
Default to JRuby 9.1.14.0 which now has some nice Java 9 support 👏
2 parents 0ebaba8 + 005183b commit e11b008

File tree

13 files changed

+22
-38
lines changed

13 files changed

+22
-38
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ buildscript {
1616
apply plugin: 'idea'
1717

1818
group = 'com.github.jruby-gradle'
19-
version = '1.6.0-SNAPSHOT'
19+
version = '1.6.0'
2020
defaultTasks 'check', 'assemble'
2121
sourceCompatibility = '1.8'
2222
targetCompatibility = '1.8'

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ releaseBuild=false
88

99
targetCompatibility=1.7
1010
sourceCompatibility=1.7
11-
jrubyVersion=9.1.12.0
11+
jrubyVersion=9.1.14.0
1212
jettyVersion=9.2.12.v20150709
1313
rubygemsProxy=http://rubygems.lasagna.io/proxy/maven/releases
1414
torqueboxProxy=http://rubygems-proxy.torquebox.org/releases

gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-4.2-bin.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-4.3.1-bin.zip

jruby-gradle-base-plugin/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ dependencies {
6161

6262
// NOTE: Leave this at .11 as it must be an older version. if
6363
// you change it here you will also need to update JRubyExecIntegrationSpec
64-
integrationTestGems "org.jruby:jruby-complete:1.7.19"
64+
integrationTestGems "org.jruby:jruby-complete:9.0.1.0"
6565

6666
// NOTE: older jruby versions needs this for exec to work properly
6767
integrationTestGems "rubygems:jar-dependencies:0.1.15"

jruby-gradle-base-plugin/src/integTest/groovy/com/github/jrubygradle/JRubyExecIntegrationSpec.groovy

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class JRubyExecIntegrationSpec extends Specification {
4444
given: "Version is set on the task"
4545
Configuration config
4646
final String configName = 'integ-exec-config'
47-
final String newVersion = '1.7.19'
47+
final String newVersion = '9.0.1.0'
4848
Pattern pattern = Pattern.compile(/.*(jruby-complete-.+.jar)/)
4949

5050
when:
@@ -161,13 +161,11 @@ class JRubyExecIntegrationSpec extends Specification {
161161

162162
def "Running a script that requires a gem, a separate JRuby and a separate configuration"() {
163163
given:
164-
final String newVersion = '1.7.19'
164+
final String newVersion = '9.0.1.0'
165165
assert project.jruby.execVersion != newVersion
166166
project.with {
167167
configurations.create('RubyWax')
168168
dependencies.add('RubyWax', VersionFinder.findDependency(FLATREPO, '', 'credit_card_validator', 'gem'))
169-
// we need it from flatrepo and not from regular repo. needed only for jruby <1.7.20
170-
dependencies.add('RubyWax', VersionFinder.findDependency(FLATREPO ,'rubygems', 'jar-dependencies', 'gem'))
171169
configure(execTask) {
172170
script "${TEST_SCRIPT_DIR}/requiresGem.rb"
173171
standardOutput output
@@ -192,7 +190,7 @@ class JRubyExecIntegrationSpec extends Specification {
192190
* least one version of JRuby installed
193191
*/
194192
jruby {
195-
execVersion '1.7.19'
193+
execVersion '9.0.1.0'
196194
defaultRepositories false
197195
}
198196

jruby-gradle-base-plugin/src/main/groovy/com/github/jrubygradle/GemUtils.groovy

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.github.jrubygradle
22

3-
import com.github.jrubygradle.internal.JRubyExecUtils
43
import org.gradle.api.Project
54
import org.gradle.api.artifacts.Configuration
65
import org.gradle.api.artifacts.ResolvedArtifact
@@ -115,12 +114,6 @@ class GemUtils {
115114
'--no-document',
116115
'--local'
117116

118-
// Workaround for bug
119-
if (JRubyExecUtils.jrubyJarVersion(jRubyClasspath) == '1.7.14') {
120-
project.logger.debug 'Gem installation: Working around bug in JRuby 1.7.14'
121-
environment HOME : project.gradle.gradleUserHomeDir.absolutePath
122-
}
123-
124117
// Workaround for FFI bug that is seen on some Windows environments
125118
if (System.getProperty('os.name').toLowerCase().startsWith('windows')) {
126119
environment 'TMP' : System.env.TMP, 'TEMP' : System.env.TEMP

jruby-gradle-base-plugin/src/main/groovy/com/github/jrubygradle/JRubyExec.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ class JRubyExec extends JavaExec implements JRubyExecTraits {
8888
* compatible with a specific version or when running a script with a different version that what will
8989
* be packaged.
9090
*
91-
* @param version String in the form '1.7.13'
91+
* @param version String in the form '9.0.1.0'
9292
* @since 0.1.18
9393
*/
9494
void jrubyVersion(final String ver) {
@@ -100,7 +100,7 @@ class JRubyExec extends JavaExec implements JRubyExecTraits {
100100
* compatible with a specific version or when running a script with a different version that what will
101101
* be packaged.
102102
*
103-
* @param version String in the form '1.7.13'
103+
* @param version String in the form '9.0.1.0'
104104
*/
105105
void setJrubyVersion(final String version) {
106106
customJRubyVersion = version

jruby-gradle-base-plugin/src/main/groovy/com/github/jrubygradle/JRubyPluginExtension.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import org.gradle.api.Project
77
* Class providing the jruby{} DSL extension to the Gradle build script
88
*/
99
class JRubyPluginExtension {
10-
static final String DEFAULT_JRUBY_VERSION = '9.1.12.0'
10+
static final String DEFAULT_JRUBY_VERSION = '9.1.14.0'
1111

1212
/** The default version of jruby that will be used */
1313
String defaultVersion = DEFAULT_JRUBY_VERSION

jruby-gradle-base-plugin/src/main/groovy/com/github/jrubygradle/internal/JRubyExecUtils.groovy

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -176,11 +176,6 @@ class JRubyExecUtils {
176176
if (!(c.dependencies.find { it.name == JRUBY_COMPLETE })) {
177177
project.dependencies.add(configuration, "org.jruby:jruby-complete:${version}")
178178
}
179-
180-
if (version.startsWith('1.7.1')) {
181-
project.dependencies.add(configuration,
182-
"rubygems:jar-dependencies:${JAR_DEPENDENCIES_VERSION}")
183-
}
184179
}
185180

186181
}

jruby-gradle-base-plugin/src/test/groovy/com/github/jrubygradle/JRubyExecSpec.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ class JRubyExecSpec extends Specification {
7676

7777
def "Changing the JRuby version with the default configuration"() {
7878
given:
79-
final String newVersion = '1.7.11'
79+
final String newVersion = '9.0.1.0'
8080
execTask.jrubyVersion = newVersion
8181

8282
when:
@@ -90,7 +90,7 @@ class JRubyExecSpec extends Specification {
9090
def "Changing the jruby version on a JRubyExec task"() {
9191
given:
9292
final String configurationName = 'spock-ruby'
93-
final String newVersion = '1.7.11'
93+
final String newVersion = '9.0.1.0'
9494

9595
when:
9696
project.configure(execTask) {

0 commit comments

Comments
 (0)