attempt to fix the previous build

Author: seuros

.github/workflows/ruby.yml

@@ -122,12 +122,21 @@ jobs:
         with:
           ruby-version: ${{ matrix.ruby-version }}
           bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Install PostgreSQL 17 client
+        run: |
+          sudo sh -c 'echo "deb http://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list'
+          wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc | sudo apt-key add -
+          sudo apt-get update
+          sudo apt-get install -y postgresql-client-17
       - name: Setup gdiff
         run: |
           sudo ln -s /usr/bin/diff /usr/bin/gdiff || true
       - name: Setup database
         run: |
           PGPASSWORD=postgres psql -h localhost -U postgres -c "CREATE USER arjdbc WITH SUPERUSER CREATEDB LOGIN PASSWORD 'arjdbc';"
+          echo "Testing connection as arjdbc user..."
+          PGPASSWORD=arjdbc psql -h localhost -d postgres -U arjdbc -c '\l'
+          echo "Exit status: $?"
           PGPASSWORD=arjdbc psql -h localhost -d postgres -c "create database activerecord_unittest;" -U arjdbc
           PGPASSWORD=arjdbc psql -h localhost -d postgres -c "create database activerecord_unittest2;" -U arjdbc
       - name: Build
@@ -273,9 +282,20 @@ jobs:
         with:
           ruby-version: ${{ matrix.ruby-version }}
           bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Install PostgreSQL 17 client
+        run: |
+          sudo sh -c 'echo "deb http://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list'
+          wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc | sudo apt-key add -
+          sudo apt-get update
+          sudo apt-get install -y postgresql-client-17
       - name: Setup PostgreSQL user
         run: |
           PGPASSWORD=postgres psql -h localhost -U postgres -c "CREATE USER arjdbc WITH SUPERUSER CREATEDB LOGIN PASSWORD 'arjdbc';"
+      - name: Test PostgreSQL connection
+        run: |
+          echo "Testing connection as arjdbc user..."
+          PGPASSWORD=arjdbc psql -h localhost -d postgres -U arjdbc -c '\l'
+          echo "Exit status: $?"
       - name: Build
         run: |
           rake jar

test/shared_helper.rb

@@ -27,8 +27,19 @@ def postgres_role?(warn = nil)
       if psql = which('psql')
         user = ENV['PGUSER'] || 'arjdbc'
         password = ENV['PGPASSWORD'] || 'arjdbc'
-        cmd = "PGPASSWORD=#{password} #{psql} -d postgres -c '\\l' -U #{user} #{psql_params} 2>&1"
-        if `#{cmd}` && $?.exitstatus == 0
+        host = ENV['PGHOST'] || 'localhost'
+        port = ENV['PGPORT'] || '5432'
+        
+        # Use simpler command with explicit parameters
+        cmd = "PGPASSWORD=#{password} #{psql} -h #{host} -p #{port} -d postgres -U #{user} -c '\\q' 2>&1"
+        
+        puts "DEBUG: Checking postgres role with command: #{cmd}"
+        output = `#{cmd}`
+        exit_status = $?.exitstatus
+        puts "DEBUG: Command output: #{output}"
+        puts "DEBUG: Exit status: #{exit_status}"
+        
+        if exit_status == 0
           true
         else
           if warn.nil?
@@ -38,6 +49,9 @@ def postgres_role?(warn = nil)
           send(:warn, warn) if warn # warn == false disables warnings
           false
         end
+      else
+        puts "DEBUG: psql executable not found!"
+        false
       end
     end
     alias_method :have_postgres?, :postgres_role?