Skip to content

Commit 74412e7

Browse files
committed
supports_views? is now a method available in 4.2 (most DBs support VIEWs)
1 parent ad41585 commit 74412e7

File tree

7 files changed

+36
-32
lines changed

7 files changed

+36
-32
lines changed

lib/arjdbc/db2/adapter.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -572,6 +572,9 @@ def drop_database(name = nil)
572572
tables.each { |table| drop_table("#{table}") }
573573
end
574574

575+
# @override
576+
def supports_views?; true end
577+
575578
def execute_table_change(sql, table_name, name = nil)
576579
outcome = execute(sql, name)
577580
reorg_table(table_name, name)

lib/arjdbc/h2/adapter.rb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,10 +196,13 @@ def quote(value, column = nil)
196196
end
197197
end
198198

199+
# @override
200+
def supports_views?; true end
201+
199202
# EXPLAIN support :
200203

201204
# @override
202-
def supports_explain?; true; end
205+
def supports_explain?; true end
203206

204207
# @override
205208
def explain(arel, binds = [])

lib/arjdbc/hsqldb/adapter.rb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,9 @@ def remove_index(table_name, options = {})
237237
execute "DROP INDEX #{quote_column_name(index_name(table_name, options))}"
238238
end
239239

240+
# @override
241+
def supports_views?; true end
242+
240243
# @override
241244
def structure_dump
242245
execute('SCRIPT').map do |result|
@@ -281,6 +284,6 @@ module ActiveRecord::ConnectionAdapters
281284
class HsqldbAdapter < JdbcAdapter
282285
include ArJdbc::HSQLDB
283286
end
284-
287+
285288
end
286289

lib/arjdbc/mssql/adapter.rb

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,9 +255,11 @@ def change_order_direction(order)
255255
end.join(",")
256256
end
257257

258-
def supports_ddl_transactions?
259-
true
260-
end
258+
# @override
259+
def supports_ddl_transactions?; true end
260+
261+
# @override
262+
def supports_views?; true end
261263

262264
def tables(schema = current_schema)
263265
@connection.tables(nil, schema)

lib/arjdbc/oracle/adapter.rb

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -485,24 +485,19 @@ def quote_raw(value)
485485
end
486486

487487
# @override
488-
def supports_migrations?
489-
true
490-
end
488+
def supports_migrations?; true end
491489

492490
# @override
493-
def supports_primary_key?
494-
true
495-
end
491+
def supports_primary_key?; true end
496492

497493
# @override
498-
def supports_savepoints?
499-
true
500-
end
494+
def supports_savepoints?; true end
501495

502496
# @override
503-
def supports_explain?
504-
true
505-
end
497+
def supports_explain?; true end
498+
499+
# @override
500+
def supports_views?; true end
506501

507502
def explain(arel, binds = [])
508503
sql = "EXPLAIN PLAN FOR #{to_sql(arel, binds)}"

lib/arjdbc/postgresql/adapter.rb

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -323,21 +323,13 @@ def supports_insert_with_returning?
323323
postgresql_version >= 80200
324324
end
325325

326-
def supports_ddl_transactions?
327-
true
328-
end
326+
def supports_ddl_transactions?; true end
329327

330-
def supports_transaction_isolation?
331-
true
332-
end
328+
def supports_transaction_isolation?; true end
333329

334-
def supports_index_sort_order?
335-
true
336-
end
330+
def supports_index_sort_order?; true end
337331

338-
def supports_partial_index?
339-
true
340-
end if AR4_COMPAT
332+
def supports_partial_index?; true end if AR4_COMPAT
341333

342334
# Range data-types weren't introduced until PostgreSQL 9.2.
343335
def supports_ranges?
@@ -348,12 +340,13 @@ def supports_transaction_isolation?(level = nil)
348340
true
349341
end
350342

343+
# @override
344+
def supports_views?; true end
345+
351346
# NOTE: handled by JdbcAdapter we override only to have save-point in logs :
352347

353348
# @override
354-
def supports_savepoints?
355-
true
356-
end
349+
def supports_savepoints?; true end
357350

358351
# @override
359352
def create_savepoint(name = current_savepoint_name(true))

lib/arjdbc/sqlite3/adapter.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,11 @@ def supports_index_sort_order?
202202
true
203203
end
204204

205+
# @override
206+
def supports_views?
207+
true
208+
end
209+
205210
def sqlite_version
206211
@sqlite_version ||= Version.new(select_value('SELECT sqlite_version(*)'))
207212
end

0 commit comments

Comments
 (0)