Skip to content

Commit 79a912c

Browse files
committed
Mysql, fix some AR test failing due mysql2_connection (database_exists? is implemented in abstract class)
1) Error: Mysql2AdapterTest#test_database_exists_returns_false_if_database_does_not_exist: NoMethodError: undefined method `mysql2_connection' for ActiveRecord::Base:Class Did you mean? connection lib/active_record/dynamic_matchers.rb:22:in `method_missing' /home/jessec/bryk/vendor_gems/activerecord-jdbc-adapter/lib/arjdbc/mysql/adapter.rb:88:in `database_exists?' test/cases/adapters/mysql2/mysql2_adapter_test.rb:83:in `test_database_exists_returns_false_if_database_does_not_exist' ...
1 parent 0b8612a commit 79a912c

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

lib/arjdbc/mysql/adapter.rb

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -84,15 +84,6 @@ def initialize(...)
8484
@connection_parameters = conn_params
8585
end
8686

87-
def self.database_exists?(config)
88-
conn = ActiveRecord::Base.mysql2_connection(config)
89-
conn && conn.really_valid?
90-
rescue ActiveRecord::NoDatabaseError
91-
false
92-
ensure
93-
conn.disconnect! if conn
94-
end
95-
9687
def supports_json?
9788
!mariadb? && database_version >= '5.7.8'
9889
end

0 commit comments

Comments
 (0)