Support options for Postgresql indexes

Author: alno

lib/arjdbc/postgresql/adapter.rb

@@ -596,7 +596,11 @@ def supports_transaction_isolation? # :nodoc:
     def supports_index_sort_order? # :nodoc:
       true
     end
-    
+
+    def supports_partial_index?
+      true
+    end if AR4_COMPAT
+
     # Range datatypes weren't introduced until PostgreSQL 9.2
     def supports_ranges? # :nodoc:
       postgresql_version >= 90200
@@ -609,7 +613,11 @@ def supports_savepoints? # :nodoc:
     def supports_transaction_isolation?(level = nil)
       true
     end
-    
+
+    def index_algorithms
+      { :concurrently => 'CONCURRENTLY' }
+    end
+
     def create_savepoint
       execute("SAVEPOINT #{current_savepoint_name}")
     end
@@ -1214,7 +1222,12 @@ def rename_column(table_name, column_name, new_column_name) # :nodoc:
       rename_column_indexes(table_name, column_name, new_column_name) if respond_to?(:rename_column_indexes) # AR-4.0 SchemaStatements
     end
 
-    def remove_index!(table_name, index_name) #:nodoc:
+    def add_index(table_name, column_name, options = {}) # :nodoc:
+      index_name, index_type, index_columns, index_options, index_algorithm, index_using = add_index_options(table_name, column_name, options)
+      execute "CREATE #{index_type} INDEX #{index_algorithm} #{quote_column_name(index_name)} ON #{quote_table_name(table_name)} #{index_using} (#{index_columns})#{index_options}"
+    end if AR4_COMPAT
+
+    def remove_index!(table_name, index_name) # :nodoc:
       execute "DROP INDEX #{quote_table_name(index_name)}"
     end
 

test/db/postgres/active_schema_unit_test.rb

@@ -0,0 +1,68 @@
+require 'test_helper'
+require 'db/postgres'
+
+class PostgreActiveSchemaUnitTest < Test::Unit::TestCase
+  
+  setup do
+    ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.class_eval do
+      def execute(sql, name = nil) sql end
+    end
+  end
+
+  teardown do
+    ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.class_eval do
+      remove_method :execute
+    end
+  end
+
+  def test_create_database_with_encoding
+    assert_equal %(CREATE DATABASE "matt" ENCODING = 'utf8'), create_database(:matt)
+    assert_equal %(CREATE DATABASE "aimonetti" ENCODING = 'latin1'), create_database(:aimonetti, :encoding => :latin1)
+    assert_equal %(CREATE DATABASE "aimonetti" ENCODING = 'latin1'), create_database(:aimonetti, 'encoding' => :latin1)
+  end
+
+  def test_create_database_with_collation_and_ctype
+    assert_equal %(CREATE DATABASE "aimonetti" ENCODING = 'UTF8' LC_COLLATE = 'ja_JP.UTF8' LC_CTYPE = 'ja_JP.UTF8'), create_database(:aimonetti, :encoding => :"UTF8", :collation => :"ja_JP.UTF8", :ctype => :"ja_JP.UTF8")
+  end
+
+  def test_add_index
+    # add_index calls index_name_exists? which can't work since execute is stubbed
+    ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.send(:define_method, :index_name_exists?) do |*|
+      false
+    end
+    redefined = true
+
+    expected = %(CREATE UNIQUE INDEX  "index_people_on_last_name" ON "people"  ("last_name") WHERE state = 'active')
+    assert_equal expected, add_index(:people, :last_name, :unique => true, :where => "state = 'active'")
+
+    expected = %(CREATE  INDEX CONCURRENTLY "index_people_on_last_name" ON "people"  ("last_name"))
+    assert_equal expected, add_index(:people, :last_name, :algorithm => :concurrently)
+
+    %w(gin gist hash btree).each do |type|
+      expected = %(CREATE  INDEX  "index_people_on_last_name" ON "people" USING #{type} ("last_name"))
+      assert_equal expected, add_index(:people, :last_name, :using => type)
+
+      expected = %(CREATE  INDEX CONCURRENTLY "index_people_on_last_name" ON "people" USING #{type} ("last_name"))
+      assert_equal expected, add_index(:people, :last_name, :using => type, :algorithm => :concurrently)
+    end
+
+    assert_raise ArgumentError do
+      add_index(:people, :last_name, :algorithm => :copy)
+    end
+    expected = %(CREATE UNIQUE INDEX  "index_people_on_last_name" ON "people" USING gist ("last_name"))
+    assert_equal expected, add_index(:people, :last_name, :unique => true, :using => :gist)
+
+    expected = %(CREATE UNIQUE INDEX  "index_people_on_last_name" ON "people" USING gist ("last_name") WHERE state = 'active')
+    assert_equal expected, add_index(:people, :last_name, :unique => true, :where => "state = 'active'", :using => :gist)
+
+  ensure
+    ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.send(:remove_method, :index_name_exists?) if redefined
+  end if ar_version('4.0')
+
+  private
+  
+  def method_missing(method_symbol, *arguments)
+    ActiveRecord::Base.connection.send(method_symbol, *arguments)
+  end
+  
+end