[mssql] test fix + due Java API refactorings #tables/#table_exists? changed

and it's probably fine that #table_exists? reports views as well - their only filtered out from #tables ... this is how most native adapters work as well

Author: kares

test/db/mssql/ignore_system_views_test.rb

@@ -5,23 +5,33 @@ class MSSQLIgnoreSystemViewsTest < Test::Unit::TestCase
   include MigrationSetup
 
   def test_system_views_ignored
+    assert_not_include tables, 'views'
     if ActiveRecord::Base.connection.sqlserver_version == "2000"
-      assert_equal false, table_exists?("sys.views"), %{table_exists?("sys.views")}
-      assert_equal false, table_exists?("information_schema.views"), %{table_exists?("information_schema.views")}
+      assert_false table_exists?("sys.views"), %{table_exists?("sys.views")}
+      assert_false table_exists?("information_schema.views"), %{table_exists?("information_schema.views")}
     else
-      assert_equal true, table_exists?("sys.views"), %{table_exists?("sys.views")}
-      assert_equal true, table_exists?("information_schema.views"), %{table_exists?("information_schema.views")}
+      assert_true table_exists?("sys.views"), %{table_exists?("sys.views")}
+      assert_true table_exists?("information_schema.views"), %{table_exists?("information_schema.views")}
+      
+      assert_true table_exists?(:views), %{table_exists?(:views)}
     end
-    assert_equal false, table_exists?("dbo.views"), %{table_exists?("dbo.views")}
-    assert_equal false, table_exists?(:views), %{table_exists?(:views)}
+    assert_false table_exists?("dbo.views"), %{table_exists?("dbo.views")}
+    #assert_false table_exists?(:views), %{table_exists?(:views)}
     ActiveRecord::Schema.define { suppress_messages { create_table :views } }
-    assert_equal true, table_exists?(:views), %{table_exists?(:views)}
+    assert_include tables, 'views'
+    assert_true table_exists?(:views), %{table_exists?(:views)}
     ActiveRecord::Schema.define { suppress_messages { drop_table :views } }
-    assert_equal false, table_exists?(:views), %{table_exists?(:views)}
+    #assert_false table_exists?(:views), %{table_exists?(:views)}
+  ensure
+    ActiveRecord::Base.connection.drop_table(:views) rescue nil
   end
 
   private
 
+  def tables
+    ActiveRecord::Base.connection.tables
+  end
+  
   def table_exists?(*args)
     ActiveRecord::Base.connection.table_exists?(*args)
   end

test/db/mssql/simple_test.rb

@@ -55,9 +55,10 @@ def test_change_column_nullability
 
   # ACTIVERECORD_JDBC-124
   def test_model_does_not_have_row_num_column
-    entry = Entry.first
-    assert_false entry.attributes.keys.include?("_row_num")
-    assert_false entry.respond_to?(:_row_num)
+    User.create! :login => 'row_num'
+    model = User.first
+    assert_false model.attributes.keys.include?("_row_num")
+    assert_false model.respond_to?(:_row_num)
   end
 
   def test_returns_charset