refactor to handle jruby version discovery errors in ScriptFactory

Author: abelsromero

ruby-tools/src/main/java/de/saumya/mojo/ruby/gems/GemsInstaller.java

@@ -241,7 +241,7 @@ private Script maybeAddArtifact(Script script, final Artifact artifact)
                             .addArg(booleanArg(this.config.isUserInstall(), "user-install"))
                             .addArg(booleanArg(this.config.isVerbose(), "verbose"));
 
-                    final JRubyVersion version = this.getVersion();
+                    final JRubyVersion version = this.factory.getVersion();
                     if (version == null || version.isLanguageLowerThan(2,6)) {
                         script.addArg(booleanArg(this.config.isAddRdoc(), "rdoc"))
                                 .addArg(booleanArg(this.config.isAddRI(), "ri"));
@@ -258,14 +258,6 @@ private Script maybeAddArtifact(Script script, final Artifact artifact)
         return script;
     }
 
-    private JRubyVersion getVersion() {
-        try {
-            return this.factory.getVersion();
-        } catch (Exception e) {
-            return null;
-        }
-    }
-
     private String booleanArg(final boolean flag, final String name) {
         return "--" + (flag ? "" : "no-") + name;
     }

ruby-tools/src/main/java/de/saumya/mojo/ruby/script/ScriptFactory.java

@@ -201,16 +201,22 @@ public void addEnvs(final String environmentVars) {
         }
     }
 
-    public JRubyVersion getVersion() throws ScriptException, IOException {
-        final ByteArrayOutputStream os = new ByteArrayOutputStream();
-        this.newArguments()
-                .addArg("-v")
-                .execute(os);
-        final String[] versionParts = os.toString(StandardCharsets.UTF_8.toString())
-                .split(" ");
-        final String jrubyVersion = versionParts[1];
-        final String languageVersion = extractLanguageVersion(versionParts[2]);
-        return new JRubyVersion(jrubyVersion, languageVersion);
+    /**
+     * Returns JRuby version representation found.
+     * {@code null} if version format could not be processed.
+     */
+    public JRubyVersion getVersion() {
+        try {
+            final ByteArrayOutputStream os = new ByteArrayOutputStream();
+            this.newArguments().addArg("-v").execute(os);
+            final String[] versionParts = os.toString(StandardCharsets.UTF_8.toString()).split(" ");
+            final String jrubyVersion = versionParts[1];
+            final String languageVersion = extractLanguageVersion(versionParts[2]);
+            return new JRubyVersion(jrubyVersion, languageVersion);
+        } catch (Exception e) {
+            logger.warn("Could not identify version: " + e.getMessage());
+            return null;
+        }
     }
 
     private String extractLanguageVersion(String versionPart) {