[refactor] add exception debugging within SSLSocket#waitSelect

Author: kares

src/main/java/org/jruby/ext/openssl/SSLSocket.java

@@ -471,8 +471,8 @@ else if ((operations & SelectionKey.OP_WRITE) != 0) {
                             writeWouldBlock(runtime, exception, result);
                         }
                     }
-                }
-                catch (IOException ioe) {
+                } catch (IOException ioe) {
+                    debugStackTrace(runtime, "SSLSocket.waitSelect", ioe);
                     throw runtime.newRuntimeError("Error with selector: " + ioe.getMessage());
                 }
             } else {
@@ -483,6 +483,7 @@ public void run() throws InterruptedException {
                             result[0] = selector.select();
                         }
                         catch (IOException ioe) {
+                            debugStackTrace(runtime, "SSLSocket.waitSelect", ioe);
                             throw runtime.newRuntimeError("Error with selector: " + ioe.getMessage());
                         }
                     }
@@ -505,32 +506,27 @@ public void wakeup() {
                     //JRuby <= 9.1.2.0 that makes this not always the case, so we have to check
                     return selector.selectedKeys().contains(key) ?  Boolean.TRUE : Boolean.FALSE;
             }
-        }
-        catch (InterruptedException interrupt) { return Boolean.FALSE; }
-        finally {
-            // Note: I don't like ignoring these exceptions, but it's
-            // unclear how likely they are to happen or what damage we
-            // might do by ignoring them. Note that the pieces are separate
-            // so that we can ensure one failing does not affect the others
-            // running.
+        } catch (InterruptedException interrupt) {
+            debug(runtime, "SSLSocket.waitSelect", interrupt);
+            return Boolean.FALSE;
+        } finally {
+            // Note: I don't like ignoring these exceptions, but it's unclear how likely they are to happen or what
+            // damage we might do by ignoring them. Note that the pieces are separate so that we can ensure one failing
+            // does not affect the others running.
 
             // clean up the key in the selector
             try {
                 if ( key != null ) key.cancel();
                 if ( selector != null ) selector.selectNow();
-            }
-            catch (Exception e) { // ignore
-                debugStackTrace(runtime, e);
+            } catch (Exception e) { // ignore
+                debugStackTrace(runtime, "SSLSocket.waitSelect (ignored)", e);
             }
 
             // shut down and null out the selector
             try {
-                if ( selector != null ) {
-                    runtime.getSelectorPool().put(selector);
-                }
-            }
-            catch (Exception e) { // ignore
-                debugStackTrace(runtime, e);
+                if ( selector != null ) runtime.getSelectorPool().put(selector);
+            } catch (Exception e) { // ignore
+                debugStackTrace(runtime, "SSLSocket.waitSelect (ignored)", e);
             }
 
             if (blocking) {
@@ -810,8 +806,11 @@ private void doShutdown() throws IOException {
         flushData(true);
     }
 
-    private IRubyObject sysreadImpl(final ThreadContext context,
-        IRubyObject len, IRubyObject buff, final boolean blocking, final boolean exception) {
+    /**
+     * @return the (@link RubyString} buffer or :wait_readable / :wait_writeable {@link RubySymbol}
+     */
+    private IRubyObject sysreadImpl(final ThreadContext context, final IRubyObject len, final IRubyObject buff,
+                                    final boolean blocking, final boolean exception) {
         final Ruby runtime = context.runtime;
 
         final int length = RubyNumeric.fix2int(len);