Skip to content

Commit c34395f

Browse files
committed
[refactor] remove redundant check
1 parent acddd54 commit c34395f

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/main/java/org/jruby/ext/openssl/BN.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -909,7 +909,7 @@ public static BigInteger getBigInteger(final IRubyObject arg) {
909909

910910
@Override
911911
public Object toJava(Class target) {
912-
if ( target.isAssignableFrom(BigInteger.class) || target == Number.class ) return value;
912+
if ( target.isAssignableFrom(BigInteger.class) ) return value;
913913
if ( target == Long.class || target == Long.TYPE ) return value.longValue();
914914
if ( target == Integer.class || target == Integer.TYPE ) return value.intValue();
915915
if ( target == Double.class || target == Double.TYPE ) return value.doubleValue();

src/test/ruby/test_bn.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ def test_comparison
7878

7979
def test_to_java
8080
assert_equal java.lang.Integer.new(42), OpenSSL::BN.new('42').to_java(:int)
81-
assert_equal java.math.BigInteger.valueOf(24), OpenSSL::BN.new('24').to_java
81+
assert_equal java.math.BigInteger.valueOf(24), val = OpenSSL::BN.new('24').to_java
82+
assert_equal java.math.BigInteger, val.class
83+
assert_equal java.math.BigInteger.valueOf(24), val = OpenSSL::BN.new('24').to_java(java.lang.Number)
8284
end if defined? JRUBY_VERSION
8385

8486
def test_new_str

0 commit comments

Comments
 (0)