exclude reporting algorithms with CFB-1 cipher mode as supported (due #35)

Author: kares

src/main/java/org/jruby/ext/openssl/Cipher.java

@@ -205,11 +205,11 @@ private static String[] registeredCipherModes(final String alg) { // e.g. "AES"
             final Provider provider = providers[i];
             final String name = provider.getName() == null ? "" : provider.getName();
             // skip those that are known to provide no Cipher engines :
-            if ( name.indexOf("JGSS") >= 0 ) continue; // SunJGSS
-            if ( name.indexOf("SASL") >= 0 ) continue; // SunSASL
-            if ( name.indexOf("XMLD") >= 0 ) continue; // XMLDSig
-            if ( name.indexOf("PCSC") >= 0 ) continue; // SunPCSC
-            if ( name.indexOf("JSSE") >= 0 ) continue; // SunJSSE
+            if ( name.contains("JGSS") ) continue; // SunJGSS
+            if ( name.contains("SASL") ) continue; // SunSASL
+            if ( name.contains("XMLD") ) continue; // XMLDSig
+            if ( name.contains("PCSC") ) continue; // SunPCSC
+            if ( name.contains("JSSE") ) continue; // SunJSSE
 
             final Provider.Service service = provider.getService("Cipher", alg);
             if ( service != null ) {
@@ -243,8 +243,9 @@ public static final class Algorithm {
         }
 
         private static final Set<String> KNOWN_BLOCK_MODES;
+        // NOTE: CFB1 does not work as (OpenSSL) expects with BC (@see GH-35)
         private static final String[] OPENSSL_BLOCK_MODES = {
-            "CBC", "CFB", "CFB1", "CFB8", "ECB", "OFB" // that Java supports
+            "CBC", "CFB", /* "CFB1", */ "CFB8", "ECB", "OFB" // that Java supports
         };
 
         static {
@@ -1145,6 +1146,7 @@ public IRubyObject do_final(final ThreadContext context) {
             }
         }
         catch (GeneralSecurityException e) { // cipher.doFinal
+            debugStackTrace(runtime, e);
             throw newCipherError(runtime, e);
         }
         catch (RuntimeException e) {

src/test/ruby/test_cipher.rb

@@ -71,6 +71,10 @@ def test_instantiate_supported_ciphers
     end
   end
 
+  def test_excludes_cfb1_ciphers # due no support in BC for CFB-1
+    assert ! OpenSSL::Cipher.ciphers.find { |name| name =~ /CFB1/i }
+  end if defined? JRUBY_VERSION
+
   def test_encrypt_decrypt_des_ede3 # borrowed from OpenSSL suite
     c1 = OpenSSL::Cipher::Cipher.new("DES-EDE3-CBC")
     c2 = OpenSSL::Cipher::DES.new(:EDE3, "CBC")