[feat] implement OpenSSL::PKey::EC#to_text (#280)

Author: kares

src/main/java/org/jruby/ext/openssl/PKey.java

@@ -369,20 +369,22 @@ protected PublicKey tryX509EncodedKey(final Ruby runtime, final KeyFactory keyFa
     }
 
     protected static void addSplittedAndFormatted(StringBuilder result, BigInteger value) {
-        String v = value.toString(16);
-        if ((v.length() % 2) != 0) {
-            v = "0" + v;
-        }
+        addSplittedAndFormatted(result, value.toString(16));
+    }
+
+    static void addSplittedAndFormatted(StringBuilder result, CharSequence v) {
+        if ((v.length() % 2) != 0) v = '0' + v.toString();
+
         String sep = "";
         for (int i = 0; i < v.length(); i += 2) {
             result.append(sep);
             if ((i % 30) == 0) {
                 result.append("\n    ");
             }
-            result.append(v.substring(i, i + 2));
+            result.append(v, i, i + 2);
             sep = ":";
         }
-        result.append("\n");
+        result.append('\n');
     }
 
     protected static CipherSpec cipherSpec(final IRubyObject cipher) {

src/main/java/org/jruby/ext/openssl/PKeyEC.java

@@ -688,6 +688,31 @@ public RubyString to_pem(ThreadContext context, final IRubyObject[] args) {
         }
     }
 
+    @JRubyMethod
+    public RubyString to_text() {
+        StringBuilder result = new StringBuilder();
+        final ECParameterSpec spec = getParamSpec();
+        result.append("Private-Key: (").append(spec.getOrder().bitLength()).append(" bit)").append('\n');
+
+        if (privateKey != null) {
+            result.append("priv:");
+            addSplittedAndFormatted(result, ((ECPrivateKey) privateKey).getS());
+        }
+
+        if (publicKey != null) {
+            result.append("pub:");
+            final byte[] pubBytes = encodeUncompressed(getGroup(true).getBitLength(), publicKey.getW());
+            final StringBuilder hexBytes = new StringBuilder(pubBytes.length * 2);
+            for (byte b: pubBytes) {
+                hexBytes.append(Integer.toHexString(Byte.toUnsignedInt(b)));
+            }
+            addSplittedAndFormatted(result, hexBytes);
+        }
+        result.append("ASN1 OID: ").append(getCurveName()).append('\n');
+
+        return RubyString.newString(getRuntime(), result);
+    }
+
     private enum PointConversion {
         COMPRESSED, UNCOMPRESSED, HYBRID;
 

src/test/ruby/ec/test_ec.rb

@@ -37,6 +37,12 @@ def test_read_pem
     #pem = key.to_pem
     #puts pem
     #assert_equal(pem, OpenSSL::PKey::EC.new(pem).to_pem)
+
+    # to_text
+    text = key.to_text
+    assert_include text, "Private-Key: (112 bit)\n"
+    assert_include text, "bb:54:b8:93:a9:51:3c:09:a6:37:f7:2c:95:2e\n"
+    assert_include text, "ASN1 OID: secp112r1\n"
   end
 
   def test_read_pem2