Skip to content

Commit 0ebde8e

Browse files
committed
more tuning for the old Rails 2.x specs
1 parent 7680b01 commit 0ebde8e

File tree

1 file changed

+33
-16
lines changed

1 file changed

+33
-16
lines changed

src/spec/ruby/rack/adapter/rails_spec.rb

Lines changed: 33 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,36 @@
55
# See the file LICENSE.txt for details.
66
#++
77

8-
require File.expand_path('spec_helper', File.dirname(__FILE__) + '/../..')
8+
require File.expand_path('../../spec_helper', File.dirname(__FILE__))
9+
10+
require 'action_controller' if defined? Rails
11+
12+
#if defined? ActionController::Base.session_options # :rails23
13+
# # avoid ArgumentError with real 2.3 (default) middleware-stack :
14+
# # A key is required to write a cookie containing the session data.
15+
# # Use config.action_controller.session = ... in config/environment.rb
16+
# ActionController::Base.session_options.update({
17+
# :key => "_testapp_session", :secret => "some secret phrase" * 42
18+
# })
19+
#else # :stub
20+
# module ActionController
21+
# class Base; end
22+
# end
23+
#end
24+
925
require 'rack/adapter/rails'
10-
require 'rack/adapter/rails_cgi'
1126

12-
if defined? ActionController::Base.session_options # :rails23
13-
# avoid ArgumentError with real 2.3 (default) middleware-stack :
14-
# A key is required to write a cookie containing the session data.
15-
# Use config.action_controller.session = ... in config/environment.rb
16-
ActionController::Base.session_options.update({
17-
:key => "_testapp_session", :secret => "some secret phrase" * 42
18-
})
19-
else # :stub
20-
module ActionController
21-
class Base; end
27+
describe 'Rack::Adapter::Rails' do
28+
29+
before :all do
30+
# avoid ArgumentError with real 2.3 (default) middleware-stack :
31+
# A key is required to write a cookie containing the session data.
32+
# Use config.action_controller.session = ... in config/environment.rb
33+
ActionController::Base.session_options.update({
34+
:key => "_testapp_session", :secret => "some secret phrase" * 42
35+
})
2236
end
23-
end
2437

25-
describe Rack::Adapter::Rails do
2638
before :each do
2739
ActionController::Base.stub(:page_cache_extension).and_return ".html"
2840
@rails = Rack::Adapter::Rails.new
@@ -67,9 +79,13 @@ class << @rails; public :instance_variable_set; end
6779
@env["jruby.rack.dynamic.requests.only"] = true
6880
@rails.call(@env).should == [200, {}, ""]
6981
end
70-
end
7182

72-
describe Rack::Adapter::RailsCgi::CGIWrapper, "#header" do
83+
end if defined? ActionController::Base.session_options # :rails23
84+
85+
require 'rack/adapter/rails_cgi'
86+
87+
describe 'Rack::Adapter::RailsCgi::CGIWrapper', "#header" do
88+
7389
before :each do
7490
@request, @response = double("request"), double("response")
7591
@request.stub(:env).and_return({"REQUEST_METHOD" => "GET"})
@@ -126,4 +142,5 @@ class << @rails; public :instance_variable_set; end
126142
@response.should_receive(:[]=).with('bza', 'hey')
127143
@wrapper.header(options)
128144
end
145+
129146
end

0 commit comments

Comments
 (0)