Skip to content

Commit 5a16cf1

Browse files
committed
[build] Declare rack dependency slightly more consistently
There was no 2.3, so this is moot, however it's clearer with later rack versions if we make this more consistent
1 parent ab9c11c commit 5a16cf1

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

.github/workflows/maven.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ env:
1010
# Default versions for canonical release build
1111
DEFAULT_JAVA_VERSION: '8'
1212
DEFAULT_JRUBY_VERSION: '9.4.13.0' # Should match pom.xml <jruby.version> property (AND a version inside the test matrix)
13-
DEFAULT_RACK_VERSION: '~> 2.2' # Should match Gemfile (AND a version inside the test matrix)
13+
DEFAULT_RACK_VERSION: '~> 2.2.0' # Should match Gemfile (AND a version inside the test matrix)
1414

1515
jobs:
1616
build:
@@ -21,7 +21,7 @@ jobs:
2121
matrix:
2222
jruby_version: [ '9.4.13.0', '10.0.2.0' ]
2323
java_version: [ '8', '11', '17', '21' ]
24-
rack_version: [ '~> 2.2' ]
24+
rack_version: [ '~> 2.2.0' ]
2525
exclude:
2626
- jruby_version: '10.0.2.0'
2727
java_version: '8' # JRuby 10 requires Java 21

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ group :default do
44
if rack_version = ENV['RACK_VERSION']
55
gem 'rack', rack_version
66
else
7-
gem 'rack', '~> 2.2'
7+
gem 'rack', '~> 2.2.0'
88
end
99
end
1010

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ PLATFORMS
3232

3333
DEPENDENCIES
3434
appraisal
35-
rack (~> 2.2)
35+
rack (~> 2.2.0)
3636
rake (~> 13.3)
3737
rspec

examples/camping/Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
source 'https://rubygems.org'
22

3-
gem 'rack', '~> 2.2'
3+
gem 'rack', '~> 2.2.0'
44
gem 'rackup'
55
gem 'camping', '< 3'
66
gem 'markaby'

examples/camping/Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ DEPENDENCIES
4040
camping (< 3)
4141
jruby-jars (< 10)
4242
markaby
43-
rack (~> 2.2)
43+
rack (~> 2.2.0)
4444
rackup
4545
warbler!
4646

src/spec/ruby/jruby/rack/integration_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ def base_path
157157
end
158158
after(:all) { restore_rails }
159159

160-
it "loaded rack ~> 2.2" do
160+
it "loaded rack ~> 2.2.0" do
161161
@runtime = @rack_factory.getApplication.getRuntime
162162
should_eval_as_not_nil "defined?(Rack.release)"
163163
should_eval_as_eql_to "Rack.release.to_s[0, 3]", '2.2'

0 commit comments

Comments
 (0)