Skip to content

Commit 5f6f41d

Browse files
committed
Fix new loggers to avoid logging at multiple levels
1 parent 6abde22 commit 5f6f41d

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

src/main/java/org/jruby/rack/logging/CommonsLoggingLogger.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,23 +49,23 @@ public boolean isEnabled(Level level) {
4949
public void log(Level level, String message) {
5050
if ( level == null ) { logger.info(message); return; }
5151
switch ( level ) {
52-
case DEBUG: logger.debug(message);
53-
case INFO: logger.info(message);
54-
case WARN: logger.warn(message);
55-
case ERROR: logger.error(message);
56-
case FATAL: logger.fatal(message);
52+
case DEBUG: logger.debug(message); break;
53+
case INFO: logger.info(message); break;
54+
case WARN: logger.warn(message); break;
55+
case ERROR: logger.error(message); break;
56+
case FATAL: logger.fatal(message); break;
5757
}
5858
}
5959

6060
@Override
6161
public void log(Level level, String message, Throwable ex) {
6262
if ( level == null ) { logger.error(message, ex); return; }
6363
switch ( level ) {
64-
case DEBUG: logger.debug(message, ex);
65-
case INFO: logger.info(message, ex);
66-
case WARN: logger.warn(message, ex);
67-
case ERROR: logger.error(message, ex);
68-
case FATAL: logger.fatal(message, ex);
64+
case DEBUG: logger.debug(message, ex); break;
65+
case INFO: logger.info(message, ex); break;
66+
case WARN: logger.warn(message, ex); break;
67+
case ERROR: logger.error(message, ex); break;
68+
case FATAL: logger.fatal(message, ex); break;
6969
}
7070
}
7171

src/main/java/org/jruby/rack/logging/Slf4jLogger.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -53,23 +53,23 @@ public boolean isEnabled(Level level) {
5353
public void log(Level level, String message) {
5454
if ( level == null ) { logger.info(message); return; }
5555
switch ( level ) {
56-
case DEBUG: logger.debug(message);
57-
case INFO: logger.info(message);
58-
case WARN: logger.warn(message);
59-
case ERROR: logger.error(message);
60-
case FATAL: logger.error(message);
56+
case DEBUG: logger.debug(message); break;
57+
case INFO: logger.info(message); break;
58+
case WARN: logger.warn(message); break;
59+
case ERROR: logger.error(message); break;
60+
case FATAL: logger.error(message); break;
6161
}
6262
}
6363

6464
@Override
6565
public void log(Level level, String message, Throwable ex) {
6666
if ( level == null ) { logger.error(message, ex); return; }
6767
switch ( level ) {
68-
case DEBUG: logger.debug(message, ex);
69-
case INFO: logger.info(message, ex);
70-
case WARN: logger.warn(message, ex);
71-
case ERROR: logger.error(message, ex);
72-
case FATAL: logger.error(message, ex);
68+
case DEBUG: logger.debug(message, ex); break;
69+
case INFO: logger.info(message, ex); break;
70+
case WARN: logger.warn(message, ex); break;
71+
case ERROR: logger.error(message, ex); break;
72+
case FATAL: logger.error(message, ex); break;
7373
}
7474
}
7575

0 commit comments

Comments
 (0)