Skip to content

Commit 8bb3744

Browse files
chadlwilsonkares
authored andcommitted
Simplify exclusion rules
1 parent 92db9eb commit 8bb3744

File tree

1 file changed

+8
-33
lines changed

1 file changed

+8
-33
lines changed

.github/workflows/maven.yml

Lines changed: 8 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ on:
66
pull_request:
77
branches: [ "master", "*release*", "*stable*" ]
88

9+
env:
10+
# Default versions for canonical release build
11+
DEFAULT_JAVA_VERSION: '8'
12+
DEFAULT_JRUBY_VERSION: '9.4.12.1' # Should match pom.xml <jruby.version> property (AND a version inside the test matrix)
13+
914
jobs:
1015
build:
1116
name: JRuby ${{ matrix.jruby_version }} / Java ${{ matrix.java_version }}
@@ -39,8 +44,8 @@ jobs:
3944

4045
# Uploads the full dependency graph to GitHub to improve the quality of Dependabot alerts this repository can receive
4146
- name: Update dependency graph
42-
uses: advanced-security/maven-dependency-submission-action@aeab9f885293af501bae8bdfe88c589528ea5e25 # v4.1.2
43-
if: github.head_ref == 'refs/heads/master' && matrix.java_version == '8' && startsWith(matrix.jruby_version, '9.4')
47+
uses: advanced-security/maven-dependency-submission-action@b275d12641ac2d2108b2cbb7598b154ad2f2cee8 # v5.0.0
48+
if: github.head_ref == 'refs/heads/master' && matrix.java_version == env.DEFAULT_JAVA_VERSION && matrix.jruby_version == env.DEFAULT_JRUBY_VERSION
4449

4550
appraisals:
4651
needs: build
@@ -54,40 +59,10 @@ jobs:
5459
appraisal: [ 'rails50', 'rails52', 'rails60', 'rails61', 'rails70', 'rails71', 'rails72' ]
5560
exclude:
5661
- jruby_version: '9.3.15.0'
57-
java_version: '8'
58-
appraisal: 'rails70' # Requires Ruby 2.7 compatibility, which JRuby 9.3 does not support
59-
- jruby_version: '9.3.15.0'
60-
java_version: '8'
61-
appraisal: 'rails71' # Requires Ruby 2.7 compatibility, which JRuby 9.3 does not support
62-
- jruby_version: '9.3.15.0'
63-
java_version: '8'
64-
appraisal: 'rails72' # Requires Ruby 3.1 compatibility, which JRuby 9.3 does not support
65-
- jruby_version: '9.3.15.0'
66-
java_version: '11'
67-
appraisal: 'rails70' # Requires Ruby 2.7 compatibility, which JRuby 9.3 does not support
68-
- jruby_version: '9.3.15.0'
69-
java_version: '11'
70-
appraisal: 'rails71' # Requires Ruby 2.7 compatibility, which JRuby 9.3 does not support
71-
- jruby_version: '9.3.15.0'
72-
java_version: '11'
73-
appraisal: 'rails72' # Requires Ruby 3.1 compatibility, which JRuby 9.3 does not support
74-
- jruby_version: '9.3.15.0'
75-
java_version: '17'
76-
appraisal: 'rails70' # Requires Ruby 2.7 compatibility, which JRuby 9.3 does not support
77-
- jruby_version: '9.3.15.0'
78-
java_version: '17'
79-
appraisal: 'rails71' # Requires Ruby 2.7 compatibility, which JRuby 9.3 does not support
80-
- jruby_version: '9.3.15.0'
81-
java_version: '17'
82-
appraisal: 'rails72' # Requires Ruby 3.1 compatibility, which JRuby 9.3 does not support
83-
- jruby_version: '9.3.15.0'
84-
java_version: '21'
8562
appraisal: 'rails70' # Requires Ruby 2.7 compatibility, which JRuby 9.3 does not support
8663
- jruby_version: '9.3.15.0'
87-
java_version: '21'
8864
appraisal: 'rails71' # Requires Ruby 2.7 compatibility, which JRuby 9.3 does not support
8965
- jruby_version: '9.3.15.0'
90-
java_version: '21'
9166
appraisal: 'rails72' # Requires Ruby 3.1 compatibility, which JRuby 9.3 does not support
9267
- jruby_version: '10.0.0.1'
9368
java_version: '8' # JRuby 10 requires Java 21
@@ -112,7 +87,7 @@ jobs:
11287
cache: maven
11388

11489
- name: Setup JRuby
115-
uses: ruby/setup-ruby@e34163cd15f4bb403dcd72d98e295997e6a55798 # v1.238.0
90+
uses: ruby/setup-ruby@13e7a03dc3ac6c3798f4570bfead2aed4d96abfb # v1.244.0
11691
with:
11792
ruby-version: jruby-${{ matrix.jruby_version }}
11893
bundler-cache: 'false' # Need to install later so we can vary from Gemfile.lock as required for JRuby version compatibility

0 commit comments

Comments
 (0)