remove LoggerSilence emulation from JRuby::Rack::Logger

Author: kares

src/main/java/org/jruby/rack/ext/Logger.java

@@ -338,8 +338,7 @@ public IRubyObject unknown(final ThreadContext context, final Block block) {
 
     // def add(severity, message = nil, progname = nil, &block)
     @JRubyMethod(name = "add", required = 1, optional = 2)
-    public IRubyObject add(final ThreadContext context,
-        final IRubyObject[] args, final Block block) {
+    public IRubyObject add(final ThreadContext context, final IRubyObject[] args, final Block block) {
         int severity = UNKNOWN;
         final IRubyObject sev = args[0];
         if ( ! sev.isNil() ) {
@@ -471,42 +470,6 @@ private void doLog(RubyString message) {
         logger.log( message );
     }
 
-    // LoggerSilence API :
-
-    private static boolean silencer = false; // we're NOT true by default!
-
-    @JRubyMethod(name= "silencer", meta = true)
-    public static IRubyObject get_silencer(final ThreadContext context, final IRubyObject self) {
-        return context.runtime.newBoolean(silencer);
-    }
-
-    @JRubyMethod(name = "silencer=", meta = true)
-    public static IRubyObject set_silencer(final ThreadContext context, final IRubyObject self,
-        final IRubyObject value) {
-        return context.runtime.newBoolean(silencer = value.isTrue());
-    }
-
-    @JRubyMethod(name = "silence")
-    public IRubyObject silence(final ThreadContext context, final Block block) {
-        return doSilence(ERROR, context, block); // temp_level = Logger::ERROR
-    }
-
-    @JRubyMethod(name = "silence", required = 1)
-    public IRubyObject silence(final ThreadContext context, final IRubyObject temp_level, final Block block) {
-        final int tempLevel = (int) temp_level.convertToInteger("to_i").getLongValue();
-        return doSilence(tempLevel, context, block);
-    }
-
-    private IRubyObject doSilence(final int tempLevel, final ThreadContext context, final Block block) {
-        if ( silencer ) {
-            // not implemented - on purpose!
-            return block.yield(context, this);
-        }
-        else {
-            return block.yield(context, this);
-        }
-    }
-
     // (old) BufferedLogger API compatibility :
 
     @JRubyMethod(name = "flush", alias = { "auto_flushing", "auto_flushing=" })

src/spec/ruby/jruby/rack/logger_spec.rb

@@ -102,19 +102,6 @@
     expect( logger.class::FATAL ).to eql 4
   end
 
-  it 'is not silencable (by default)' do
-    expect( JRuby::Rack::Logger.silencer ).to be false
-  end
-
-  it 'supports silence with block' do
-    called = nil
-    logger.silence do |logger|
-      called = true
-      expect( logger ).to be logger
-    end
-    expect( called ).to be true
-  end
-
   describe JRuby::Rack::ServletLog do
     let(:servlet_context_logger) do
       org.jruby.rack.logging.ServletContextLogger.new(servlet_context)