[chore] Tidy deprecation annotations

(cherry picked from commit 08ba154)

Author: chadlwilson

src/main/java/org/jruby/rack/servlet/ResponseCapture.java

@@ -82,7 +82,7 @@ public void setStatus(int status) {
 
     @Override
     @Deprecated // Deprecated in API parent
-    @SuppressWarnings("deprecation")
+    @SuppressWarnings("deprecation") // Deprecated in API parent
     public void setStatus(int status, String message) {
         if ( handleStatus(status, false) ) {
             super.setStatus(status, message);

src/spec/java/org/jruby/rack/fake/FakePageContext.java

@@ -27,12 +27,11 @@
 /**
  * Currently only used as a mock for testing.
  */
-@SuppressWarnings("deprecation")
 public class FakePageContext extends PageContext {
-    private ServletContext context;
-    private ServletRequest request;
-    private ServletResponse response;
-    private JspWriter out;
+    private final ServletContext context;
+    private final ServletRequest request;
+    private final ServletResponse response;
+    private final JspWriter out;
 
     public FakePageContext(ServletContext context, HttpServletRequest request, HttpServletResponse response, JspWriter out) {
         this.context = context;
@@ -46,7 +45,7 @@ public Object findAttribute(String arg0) {
     }
 
     @Override
-    public void forward(String arg0) throws ServletException, IOException {
+    public void forward(String arg0) {
         throw new UnsupportedOperationException("Not supported yet. forward");
     }
 
@@ -111,12 +110,12 @@ public HttpSession getSession() {
     }
 
     @Override
-    public void handlePageException(Exception arg0) throws ServletException, IOException {
+    public void handlePageException(Exception arg0) {
         throw new UnsupportedOperationException("Not supported yet. handlePageException");
     }
 
     @Override
-    public void handlePageException(Throwable arg0) throws ServletException, IOException {
+    public void handlePageException(Throwable arg0) {
         throw new UnsupportedOperationException("Not supported yet. handlePageException");
     }
 
@@ -126,7 +125,7 @@ public void include(String arg0) throws ServletException, IOException {
     }
 
     @Override
-    public void initialize(Servlet arg0, ServletRequest arg1, ServletResponse arg2, String arg3, boolean arg4, int arg5, boolean arg6) throws IOException, IllegalStateException, IllegalArgumentException {
+    public void initialize(Servlet arg0, ServletRequest arg1, ServletResponse arg2, String arg3, boolean arg4, int arg5, boolean arg6) throws IllegalStateException, IllegalArgumentException {
         throw new UnsupportedOperationException("Not supported yet. initialize");
     }
 
@@ -161,11 +160,13 @@ public void include(String arg0, boolean arg1) throws ServletException, IOExcept
     }
 
     @Override
+    @Deprecated // Deprecated in API parent
     public ExpressionEvaluator getExpressionEvaluator() {
         throw new UnsupportedOperationException("Not supported yet.");
     }
 
     @Override
+    @Deprecated // Deprecated in API parent
     public VariableResolver getVariableResolver() {
         throw new UnsupportedOperationException("Not supported yet.");
     }

src/spec/java/org/jruby/rack/mock/RackLoggingMockServletContext.java

@@ -60,7 +60,8 @@ public void log(String message) {
     }
 
     @Override
-    @SuppressWarnings("deprecation")
+    @Deprecated // Deprecated in API parent
+    @SuppressWarnings("deprecation") // Deprecated in API parent
     public void log(Exception ex, String message) {
         logger.log(message, ex);
     }