Skip to content

Commit a4fc42f

Browse files
committed
[test] Remove old servlet API < 3 support code
1 parent c42f121 commit a4fc42f

File tree

3 files changed

+1
-36
lines changed

3 files changed

+1
-36
lines changed

src/spec/ruby/rack/handler/servlet_spec.rb

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -884,22 +884,7 @@ def servlet.create_env(servlet_env)
884884
env = servlet.create_env @servlet_env
885885

886886
expect(env['java.servlet_context']).to_not be nil
887-
if servlet_30?
888-
expect(env['java.servlet_context']).to be @servlet_context
889-
else
890-
expect(env['java.servlet_context']).to be @rack_context
891-
892-
# HACK to emulate Servlet API 3.0 MockHttpServletRequest has getServletContext :
893-
env = Rack::Handler::Servlet::DefaultEnv.new(@servlet_request).to_hash
894-
895-
expect(env['java.servlet_context']).to_not be nil
896-
expect(env['java.servlet_context']).to be @servlet_context
897-
begin
898-
expect(env['java.servlet_context']).to eq @servlet_context
899-
rescue NoMethodError
900-
expect((env['java.servlet_context'] == @servlet_context)).to eq true
901-
end
902-
end
887+
expect(env['java.servlet_context']).to be @servlet_context
903888
end
904889

905890
it "returns the servlet request when queried with java.servlet_request" do

src/spec/ruby/rack/servlet/response_capture_spec.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,6 @@
7676
end
7777

7878
it "is considered handled when more than Allow header is added with OPTIONS" do
79-
pending "need Servlet API 3.0" unless servlet_30?
80-
8179
servlet_request.method = 'OPTIONS'
8280

8381
response_capture.setIntHeader "Answer", 42
@@ -87,8 +85,6 @@
8785
end
8886

8987
it "is considered handled when header is added" do
90-
pending "need Servlet API 3.0" unless servlet_30?
91-
9288
servlet_request.method = 'OPTIONS'
9389

9490
response_capture.addHeader "Hello", "World"

src/spec/ruby/spec_helper.rb

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -54,22 +54,6 @@ def silence_warnings(&block)
5454
JRuby::Rack::Helpers.silence_warnings(&block)
5555
end
5656

57-
@@servlet_30 = nil
58-
59-
def servlet_30?
60-
return @@servlet_30 unless @@servlet_30.nil?
61-
@@servlet_30 = !!(Java::javax.servlet.AsyncContext rescue nil)
62-
end
63-
64-
private :servlet_30?
65-
66-
def rack_release_at_least?(at_least = nil)
67-
require 'rack';
68-
at_least ? Rack.release >= at_least : true
69-
end
70-
71-
private :rack_release_at_least?
72-
7357
def raise_logger(level = 'WARN')
7458
org.jruby.rack.logging.RaiseLogger.new(level, JRuby.runtime.out)
7559
end

0 commit comments

Comments
 (0)