setting of relative_url_root isn't really needed

since the Rails::Configuration default is:

  @relative_url_root = ENV["RAILS_RELATIVE_URL_ROOT"]

Author: kares

src/main/ruby/jruby/rack/rails/railtie.rb

@@ -45,23 +45,6 @@ class Railtie < ::Rails::Railtie
       end
     end
 
-    initializer 'set_relative_url_root', :after => 'action_controller.set_configs' do |app|
-      # NOTE: this is most likely handled by Rails 3.x itself :
-      # - *config.relative_url_root* since 3.2 defaults to _RAILS_RELATIVE_URL_ROOT_
-      # - *config.action_controller.relative_url_root* is set from *config.relative_url_root*
-      # - when a *config.relative_url_root* is set we should not interfere ...
-      if ( env_url_root = ENV['RAILS_RELATIVE_URL_ROOT'] ) &&
-        !( app.config.respond_to?(:relative_url_root) && app.config.relative_url_root )
-        if action_controller = app.config.action_controller
-          action_controller.relative_url_root = env_url_root
-        elsif defined?(ActionController::Base) &&
-          ActionController::Base.respond_to?(:relative_url_root=)
-          # setting the config affects *ActionController::Base.relative_url_root*
-          ActionController::Base.config.relative_url_root = env_url_root
-        end
-      end
-    end
-
     initializer 'action_dispatch.autoload_java_servlet_store', :after => 'action_dispatch.configure' do
       # if it's loaded up front with a require 'action_controller'/'action_dispatch' then
       # it might fire up before 'active_record' has been required causing sweeping issues

src/spec/ruby/jruby/rack/rails_booter_spec.rb

@@ -242,63 +242,6 @@ def log_initializer
       booter.to_app.should == app
     end
 
-    it "should set config.action_controller.relative_url_root based on ENV['RAILS_RELATIVE_URL_ROOT']" do
-      ENV['RAILS_RELATIVE_URL_ROOT'] = '/blah'
-      app = double "app"
-      app.stub_chain(:config, :action_controller, :relative_url_root)
-      app.config.action_controller.should_receive(:relative_url_root=).with("/blah")
-      before_config = Rails::Railtie.__initializer.detect { |i| i.first =~ /url/ }
-      before_config.should_not be_nil
-      before_config[1].should == [{:after => "action_controller.set_configs"}]
-      before_config.last.call(app)
-    end
-
-  end # if defined? Rails
-
-  # NOTE: specs currently only test with a stubbed Rails::Railtie
-  describe "Rails 3.1", :lib => [ :stub ] do
-
-    before :each do
-      $servlet_context = @servlet_context
-      #booter.layout_class = JRuby::Rack::FileSystemLayout
-      booter.app_path = RAILS_ROOT_DIR.dup
-      def booter.rails2?; false end
-      booter.boot!
-      booter.load_environment
-    end
-
-    after :all do
-      $servlet_context = nil
-    end
-
-    #
-    # relative_url_root= has been deprecated in Rails > 3. We should not call it when it's not defined.
-    # See: https://github.com/jruby/jruby-rack/issues/73
-    #      https://github.com/rails/rails/issues/2435
-    #
-    it "should not set config.action_controller.relative_url_root if the controller doesn't respond to that method" do
-      require 'action_controller' # stub
-      begin
-        #ActionController::Base.send :remove_method, :relative_url_root=
-        ENV['RAILS_RELATIVE_URL_ROOT'] = '/blah'
-        app = double "app"
-        app.stub_chain(:config, :action_controller)
-        app.config.stub(:action_controller).and_return(nil)
-        # app.config.action_controller.should_not_receive(:relative_url_root=)
-        ActionController::Base.stub(:config).and_return app.config
-
-        app.config.should_receive(:relative_url_root=).with('/blah')
-        ActionController::Base.should_not_receive(:relative_url_root=)
-
-        init = Rails::Railtie.__initializer.detect { |i| i.first =~ /url/ }
-        init.should_not be nil
-        init[1].should == [{:after => "action_controller.set_configs"}]
-        init.last.call(app)
-      ensure
-        #ActionController::Base.send :attr_writer, :relative_url_root
-      end
-    end
-
   end # if defined? Rails
 
 end