Skip to content

Commit b6aee9c

Browse files
kareschadlwilson
authored andcommitted
cleanup some comments and add missing overrides
(cherry picked from commit e593d43)
1 parent 041ba54 commit b6aee9c

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

src/main/java/org/jruby/rack/DefaultRackConfig.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -195,12 +195,6 @@ protected RackLogger createLogger(final String loggerClass) {
195195
throw new RackException("could not create logger: '" + loggerClass + "'", e.getTargetException());
196196
}
197197
}
198-
//catch (ClassNotFoundException e) {
199-
// if ( ! isQuiet() ) {
200-
// err.println("failed creating logger: '" + loggerClass + "'");
201-
// e.printStackTrace(err);
202-
// }
203-
//}
204198
catch (Exception e) {
205199
if ( ! isQuiet() ) {
206200
err.println("failed creating logger: '" + loggerClass + "'");

src/main/java/org/jruby/rack/RackContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* @author nicksieger
1414
*/
1515
public interface RackContext extends RackLogger {
16-
RackConfig getConfig(); /// NOTE: deprecate ?
16+
RackConfig getConfig();
1717
String getServerInfo();
1818
// TODO more methods from ServletContext here ?!
1919
}

src/main/java/org/jruby/rack/RackServletContextListener.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ public RackServletContextListener() {
3939
this.factory = factory;
4040
}
4141

42+
@Override
4243
public void contextInitialized(final ServletContextEvent event) {
4344
final ServletContext context = event.getServletContext();
4445
final ServletRackConfig config = new ServletRackConfig(context);
@@ -54,6 +55,7 @@ public void contextInitialized(final ServletContextEvent event) {
5455
}
5556
}
5657

58+
@Override
5759
public void contextDestroyed(final ServletContextEvent event) {
5860
final ServletContext context = event.getServletContext();
5961
final RackApplicationFactory factory =

0 commit comments

Comments
 (0)