Skip to content

Commit bd75d3f

Browse files
committed
use a Set by default since the days of Arrays.asList( 404 ) seem to be long over
1 parent 9227d75 commit bd75d3f

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

src/main/java/org/jruby/rack/UnmappedRackFilter.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,20 @@ public class UnmappedRackFilter extends AbstractFilter {
4545

4646
private boolean responseHandledByDefault = true;
4747

48-
private Collection<Integer> responseNotHandledStatuses =
48+
private static final Collection<Integer> RESPONSE_NOT_HANDLED_STATUSES;
49+
static {
50+
final HashSet<Integer> statuses = new HashSet<Integer>(8, 1);
51+
statuses.add( 404 );
4952
// 403 due containers not supporting PUT/DELETE correctly (Tomcat 6)
53+
statuses.add( 403 );
5054
// 405 returned by Jetty 7/8 on PUT/DELETE requests by default
55+
statuses.add( 405 );
5156
// 501 is returned for non standard http verbs like PATCH
52-
Collections.unmodifiableList( Arrays.asList(404, 403, 405, 501) );
57+
statuses.add( 501 );
58+
RESPONSE_NOT_HANDLED_STATUSES = Collections.unmodifiableSet(statuses);
59+
}
60+
61+
private Collection<Integer> responseNotHandledStatuses = RESPONSE_NOT_HANDLED_STATUSES;
5362
private RackContext context;
5463
private RackDispatcher dispatcher;
5564

0 commit comments

Comments
 (0)