Skip to content

Commit c3b9709

Browse files
committed
[fix] Add missing 'debug' zero-argument logging signature
-Fixes #329
1 parent aec8af5 commit c3b9709

File tree

3 files changed

+29
-0
lines changed

3 files changed

+29
-0
lines changed

History.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@
1919
- Change context listener to throw, in case of an exception during initialization, by default
2020
- Change rails context listener to assume a thread-safe application by default
2121

22+
## 1.2.6 (UNRELEASED)
23+
24+
- Add missing block-only signature for debug logging
25+
2226
## 1.2.5
2327

2428
- Fix use of jruby-rack under Java 8 (#324)

src/main/java/org/jruby/rack/ext/Logger.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,11 @@ public IRubyObject debug(final ThreadContext context,
243243
return context.runtime.newBoolean( add(DEBUG, context, msg, block) );
244244
}
245245

246+
@JRubyMethod(name = "debug")
247+
public IRubyObject debug(final ThreadContext context, final Block block) {
248+
return debug(context, context.nil, block);
249+
}
250+
246251
//
247252
// :call-seq:
248253
// info(message)

src/spec/ruby/jruby/rack/logger_spec.rb

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,26 @@
8686
expect(logger.warn?).to be true
8787
end
8888

89+
[:debug, :info, :warn, :error, :fatal].each do |level|
90+
it "logs at #{level} level" do
91+
logger.public_send(level, 'message')
92+
expect(real_logger.logged_content).to eql "#{level.to_s.upcase}: message\n"
93+
94+
real_logger.reset
95+
logger.public_send(level, 'message') { 'ignored' }
96+
expect(real_logger.logged_content).to eql "#{level.to_s.upcase}: message\n"
97+
98+
real_logger.reset
99+
logger.public_send(level, nil) { 'message' }
100+
expect(real_logger.logged_content).to eql "#{level.to_s.upcase}: message\n"
101+
102+
103+
real_logger.reset
104+
logger.public_send(level) { 'message' }
105+
expect(real_logger.logged_content).to eql "#{level.to_s.upcase}: message\n"
106+
end
107+
end
108+
89109
it "disables real logger's formatting when formatter is set" do
90110
real_logger.formatting = true
91111
expect(real_logger.formatting?).to be true

0 commit comments

Comments
 (0)