Skip to content

Commit c5e6b58

Browse files
committed
[chore] Add missing override declarations
1 parent b8ab27f commit c5e6b58

File tree

9 files changed

+42
-0
lines changed

9 files changed

+42
-0
lines changed

src/main/java/org/jruby/rack/AbstractFilter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public abstract class AbstractFilter implements Filter {
4747
* @throws IOException if there's an IO exception
4848
* @throws ServletException if there's a servlet exception
4949
*/
50+
@Override
5051
public final void doFilter(
5152
ServletRequest request, ServletResponse response,
5253
FilterChain chain) throws IOException, ServletException {

src/main/java/org/jruby/rack/AbstractRackDispatcher.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ public AbstractRackDispatcher(RackContext context) {
2626
this.context = context;
2727
}
2828

29+
@Override
2930
public void process(RackEnvironment request, RackResponseEnvironment response)
3031
throws IOException {
3132

src/main/java/org/jruby/rack/DefaultErrorApplication.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ private class Response implements RackResponse {
8484

8585
public Response(RackEnvironment env) { this.env = env; }
8686

87+
@Override
8788
public int getStatus() {
8889
return status;
8990
}
@@ -93,6 +94,7 @@ public void setStatus(int status) {
9394
this.status = status;
9495
}
9596

97+
@Override
9698
public Map<String, ?> getHeaders() {
9799
return headers;
98100
}
@@ -102,6 +104,7 @@ public void setHeaders(Map<String, ?> headers) {
102104
this.headers = headers == null ? Collections.emptyMap() : headers;
103105
}
104106

107+
@Override
105108
public String getBody() {
106109
if ( body == null ) {
107110
try {
@@ -135,6 +138,7 @@ protected String buildErrorBody() {
135138
return stringWriter.toString();
136139
}
137140

141+
@Override
138142
public void respond(RackResponseEnvironment response) {
139143
try {
140144
defaultRespond(this, response);

src/main/java/org/jruby/rack/ErrorApplicationHandler.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,19 @@ public void setError(Exception error) {
5959
this.error = error;
6060
}
6161

62+
@Override
6263
public RackResponse call(final RackEnvironment env) {
6364
env.setAttribute(RackEnvironment.EXCEPTION, getError());
6465
return getErrorApplication().call(env);
6566
}
6667

68+
@Override
6769
public void init() { getErrorApplication().init(); }
6870

71+
@Override
6972
public void destroy() { getErrorApplication().destroy(); }
7073

74+
@Override
7175
public Ruby getRuntime() {
7276
return getErrorApplication().getRuntime();
7377
}

src/main/java/org/jruby/rack/embed/Config.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,30 +73,37 @@ protected String resolveProperty(String key) {
7373
return value;
7474
}
7575

76+
@Override
7677
public final String getProperty(String key) {
7778
return delegate.getProperty(key);
7879
}
7980

81+
@Override
8082
public final String getProperty(String key, String defaultValue) {
8183
return delegate.getProperty(key, defaultValue);
8284
}
8385

86+
@Override
8487
public final Boolean getBooleanProperty(String key) {
8588
return delegate.getBooleanProperty(key);
8689
}
8790

91+
@Override
8892
public final Boolean getBooleanProperty(String key, Boolean defaultValue) {
8993
return delegate.getBooleanProperty(key, defaultValue);
9094
}
9195

96+
@Override
9297
public final Number getNumberProperty(String key) {
9398
return delegate.getNumberProperty(key);
9499
}
95100

101+
@Override
96102
public final Number getNumberProperty(String key, Number defaultValue) {
97103
return delegate.getNumberProperty(key, defaultValue);
98104
}
99105

106+
@Override
100107
public RackLogger getLogger() {
101108
if (logger == null) {
102109
logger = delegate.getLogger();
@@ -108,6 +115,7 @@ public void setLogger(RackLogger logger) {
108115
this.logger = logger;
109116
}
110117

118+
@Override
111119
public PrintStream getOut() {
112120
return delegate.getOut();
113121
}
@@ -116,6 +124,7 @@ public void setOut(OutputStream out) {
116124
delegate.setOut(out);
117125
}
118126

127+
@Override
119128
public PrintStream getErr() {
120129
return delegate.getErr();
121130
}
@@ -124,66 +133,81 @@ public void setErr(OutputStream err) {
124133
delegate.setErr(err);
125134
}
126135

136+
@Override
127137
public boolean isRewindable() {
128138
return delegate.isRewindable();
129139
}
130140

141+
@Override
131142
public Integer getInitialMemoryBufferSize() {
132143
return delegate.getInitialMemoryBufferSize();
133144
}
134145

146+
@Override
135147
public Integer getMaximumMemoryBufferSize() {
136148
return delegate.getMaximumMemoryBufferSize();
137149
}
138150

151+
@Override
139152
public String getRackup() {
140153
return delegate.getRackup();
141154
}
142155

156+
@Override
143157
public String getRackupPath() {
144158
return delegate.getRackupPath();
145159
}
146160

147161
// runtime pooling in embedded ENVs not implemented :
148162

163+
@Override
149164
public Integer getRuntimeTimeoutSeconds() {
150165
throw new UnsupportedOperationException("getRuntimeTimeoutSeconds()");
151166
}
152167

168+
@Override
153169
public Integer getInitialRuntimes() {
154170
throw new UnsupportedOperationException("getInitialRuntimes()");
155171
}
156172

173+
@Override
157174
public Integer getMaximumRuntimes() {
158175
throw new UnsupportedOperationException("getMaximumRuntimes()");
159176
}
160177

178+
@Override
161179
public String[] getRuntimeArguments() {
162180
throw new UnsupportedOperationException("getRuntimeArguments()");
163181
}
164182

183+
@Override
165184
public Integer getNumInitializerThreads() {
166185
throw new UnsupportedOperationException("getNumInitializerThreads()");
167186
}
168187

188+
@Override
169189
public boolean isSerialInitialization() {
170190
throw new UnsupportedOperationException("isSerialInitialization()");
171191
}
172192

193+
@Override
173194
public boolean isIgnoreEnvironment() {
174195
throw new UnsupportedOperationException("isIgnoreEnvironment()");
175196
}
176197

198+
@Override
177199
public Map<String, String> getRuntimeEnvironment() {
178200
throw new UnsupportedOperationException("getRuntimeEnvironment()");
179201
}
180202

181203
// RackFilter aint's used with embed :
182204

205+
@Override
183206
public boolean isFilterAddsHtml() {
184207
throw new UnsupportedOperationException("isFilterAddsHtml()");
185208
}
186209

210+
@Override
187211
public boolean isFilterVerifiesResource() {
188212
throw new UnsupportedOperationException("isFilterVerifiesResource()");
189213
}

src/main/java/org/jruby/rack/ext/Response.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,7 @@ public IRubyObject headers(final ThreadContext context) {
270270
* @return the response status
271271
* @see RackResponse#getStatus()
272272
*/
273+
@Override
273274
public int getStatus() {
274275
return this.status;
275276
}
@@ -278,6 +279,7 @@ public int getStatus() {
278279
* @return the headers hash
279280
* @see RackResponse#getHeaders()
280281
*/
282+
@Override
281283
@SuppressWarnings("unchecked")
282284
public Map<String, ?> getHeaders() {
283285
return this.headers;
@@ -287,6 +289,7 @@ public int getStatus() {
287289
* @return the response body (build up as a string)
288290
* @see RackResponse#getBody()
289291
*/
292+
@Override
290293
public String getBody() {
291294
if ( this.body instanceof RubyString ) return this.body.asJavaString();
292295
// body = ""; @body.each { |part| body << part }; body
@@ -320,6 +323,7 @@ public IRubyObject yield(ThreadContext context, IRubyObject part) {
320323
* Respond this response with the given (servlet) response environment.
321324
* @see RackResponse#respond(RackResponseEnvironment)
322325
*/
326+
@Override
323327
public void respond(final RackResponseEnvironment response) throws RackException {
324328
if ( ! response.isCommitted() ) {
325329
try { // NOTE: we're assuming possible overrides are out of our NS

src/main/java/org/jruby/rack/servlet/RequestCapture.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,12 @@ public Enumeration<String> getParameterNames() {
8080
if ( requestParametersParsed() ) {
8181
return new Enumeration<String>() {
8282
final Iterator<String> keys = requestParams.keySet().iterator();
83+
@Override
8384
public boolean hasMoreElements() {
8485
return keys.hasNext();
8586
}
8687

88+
@Override
8789
public String nextElement() {
8890
return keys.next();
8991
}

src/main/java/org/jruby/rack/servlet/ResponseCapture.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ public ResponseCapture(HttpServletResponse response) {
4646
* @return the status set using one of the set status methods
4747
* @see #handleStatus(int, boolean)
4848
*/
49+
@Override
4950
public int getStatus() {
5051
return status != null ? status : 200;
5152
}

src/main/java/org/jruby/rack/servlet/ServletRackResponseEnvironment.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ public ServletRackResponseEnvironment(HttpServletResponse response) {
2727
super(response);
2828
}
2929

30+
@Override
3031
@Deprecated
3132
public void defaultRespond(final RackResponse response) throws IOException {
3233
DefaultErrorApplication.defaultRespond(response, this);

0 commit comments

Comments
 (0)