Skip to content

Commit f681243

Browse files
committed
back to using Java-style servlet method names - to be uniform across jruby-rack
1 parent f73df50 commit f681243

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/main/ruby/rack/handler/servlet/servlet_env.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def load_env_key(env, key)
4646
# Load parameters into the (Rack) env from the Servlet API.
4747
# using javax.servlet.http.HttpServletRequest#getParameterMap
4848
def load_parameters
49-
method = @servlet_env.method || 'GET'
49+
method = @servlet_env.getMethod || 'GET'
5050
get_only = ( method == 'GET' || method == 'HEAD' )
5151
# we only need to really do this for POSTs but we'll handle all
5252
query_hash, form_hash = {}, {}
@@ -56,7 +56,7 @@ def load_parameters
5656
# - multi values are kept even when they do not end with '[]'
5757
# - if there's a query param and the same param name is in the (POST)
5858
# body, both are kept and present as a multi-value
59-
@servlet_env.parameter_map.each do |key, val| # String, String[]
59+
@servlet_env.getParameterMap.each do |key, val| # String, String[]
6060
if get_only || ( q_vals = query_values(key) )
6161
if q_vals.length != val.length
6262
# some are GET params some POST params
@@ -109,7 +109,7 @@ def store_parameter(key, val, hash)
109109
# using javax.servlet.http.HttpServletRequest#getCookies
110110
def load_cookies
111111
cookie_hash = {}
112-
(@servlet_env.cookies || []).each do |cookie| # getCookies
112+
(@servlet_env.getCookies || []).each do |cookie|
113113
name = cookie.name
114114
if cookie_hash[name]
115115
# NOTE: Rack compatible only accepting a single value
@@ -126,7 +126,7 @@ def load_cookies
126126
private
127127

128128
def query_string
129-
@query_string ||= @servlet_env.query_string.to_s # getQueryString
129+
@query_string ||= @servlet_env.getQueryString.to_s
130130
end
131131

132132
def query_values(key)
@@ -137,7 +137,7 @@ def query_values(key)
137137
end
138138

139139
def parse_query_string
140-
Java::JavaxServletHttp::HttpUtils.parse_query_string(query_string)
140+
Java::JavaxServletHttp::HttpUtils.parseQueryString(query_string)
141141
end
142142

143143
end

0 commit comments

Comments
 (0)