Skip to content

Using polyglot extension #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 29, 2024
Merged

Using polyglot extension #11

merged 6 commits into from
Oct 29, 2024

Conversation

@mkristian
Copy link
Member

@mkristian mkristian commented Sep 1, 2024

using the new maven and the new polyglot-ruby to setup the ruby extension

This setup is done inside the maven distribution itself and thus need no extra configuration to use ruby DSL pom.rb or Mavenfile.

Updated the version to follow the base version of the maven distribution itself (3.9.)

@mkristian mkristian requested a review from headius September 1, 2024 17:34
@mkristian mkristian self-assigned this Sep 1, 2024
@mkristian mkristian mentioned this pull request Sep 1, 2024
Merged
@headius
Copy link
Member

headius commented Sep 2, 2024

Nice! I'll review and merge tomorrow.

@mkristian mkristian mentioned this pull request Sep 7, 2024
Closed
@headius
Copy link
Member

headius commented Sep 10, 2024

I held off on merging because you mentioned the errors. Are you looking into these or should I try?

@mkristian mkristian force-pushed the using-polyglot-extension branch from 65faf70 to a68e7e4 Compare September 29, 2024 12:21
@mkristian
Copy link
Member Author

mkristian commented Sep 29, 2024

@headius my performance speed and response time is horrible.

I fixed the spec, something odd with directory name extensions, do I changed it to something mode specific.

But if you could test the new gem in one or two scenario, like a docker container or anything without any cached maven artifacts, that would be great.

headius
headius approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@headius headius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@headius
Copy link
Member

headius commented Oct 10, 2024

@mkristian I can give it a test here but just updating the ruby-maven-libs gem has worked around the Docker problem already. I'm not sure if I'd be able to reproduce the issue even if I tried!

I'll push a preview version of the gem and a PR for JRuby to test it!

@headius
Copy link
Member

headius commented Oct 10, 2024

jruby/jruby#8372

@headius
Copy link
Member

headius commented Oct 10, 2024

Difficult to test on gem install, because the jar-dependencies seems to only install released gems?

$ gem install psych            
  jar dependencies for psych-5.1.2-java.gemspec . . .
Installing gem 'ruby-maven' . . .
Fetching ruby-maven-libs-3.3.9.gem
Fetching ruby-maven-3.3.13.gem
Successfully installed ruby-maven-libs-3.3.9
Successfully installed ruby-maven-3.3.13
Parsing documentation for ruby-maven-libs-3.3.9
Installing ri documentation for ruby-maven-libs-3.3.9
Parsing documentation for ruby-maven-3.3.13
Installing ri documentation for ruby-maven-3.3.13
Done installing documentation for ruby-maven-libs, ruby-maven after 0 seconds
Parsing documentation for ruby-maven-3.3.13
Parsing documentation for ruby-maven-libs-3.3.9
Done installing documentation for ruby-maven, ruby-maven-libs after 0 seconds

using maven for the first time results in maven
downloading all its default plugin and can take time.
as those plugins get cached on disk and further execution
of maven is much faster then the first time.

ERROR:  While executing gem ... (Errno::ENOENT)
    No such file or directory - /Users/headius/work/jruby/lib/ruby/stdlib/polyglot_jars
	org/jruby/RubyDir.java:132:in `initialize'
	org/jruby/RubyClass.java:922:in `new'
	/Users/headius/work/jruby/lib/ruby/stdlib/ruby_maven.rb:73:in `launch'
	/Users/headius/work/jruby/lib/ruby/stdlib/ruby_maven.rb:47:in `exec'
	/Users/headius/work/jruby/lib/ruby/stdlib/maven/ruby/maven.rb:112:in `exec'
	/Users/headius/work/jruby/lib/ruby/stdlib/jars/maven_exec.rb:79:in `resolve_dependencies_list'
	/Users/headius/work/jruby/lib/ruby/stdlib/jars/installer.rb:233:in `install_dependencies'
	/Users/headius/work/jruby/lib/ruby/stdlib/jars/installer.rb:224:in `do_install'
	/Users/headius/work/jruby/lib/ruby/stdlib/jars/installer.rb:170:in `vendor_jars'
	/Users/headius/work/jruby/lib/ruby/stdlib/jars/post_install_hook.rb:28:in `block in <main>'

@headius headius mentioned this pull request Oct 22, 2024
Closed
@headius
Copy link
Member

headius commented Oct 29, 2024

Time to just go for it and we'll deal with any fallout. jar-dependencies needs the ruby-maven release to really test properly, so let's do that.

@headius headius merged commit 72e6b8b into master Oct 29, 2024
6 checks passed
@headius headius deleted the using-polyglot-extension branch October 29, 2024 17:37
@headius headius modified the milestone: 3.4 Oct 29, 2024
@headius headius mentioned this pull request Oct 29, 2024
Closed
@headius headius mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@headius headius headius approved these changes

Assignees

@mkristian mkristian

Labels

None yet

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@mkristian @headius