Skip to content

Commit 6f5d20b

Browse files
authored
Merge pull request #123 from jrzaurin/joss_review_tiny_changes
Joss review tiny changes
2 parents b04716b + d35bcf9 commit 6f5d20b

File tree

4 files changed

+22
-15
lines changed

4 files changed

+22
-15
lines changed

CONTRIBUTING.MD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pytorch-widedeep is being developed and used by many active community members. Your help is very valuable to make it better for everyone.
22

3-
- **[TBA]** Check for the [Roadmap](https://github.com/jrzaurin/pytorch-widedeep/projects/1) or [Open an issue](https://github.com/microsoft/jrzaurin/pytorch-widedeep/issues) to report problems or recommend new features and submit a draft pull requests, which will be changed to pull request after intial review
3+
- Check for the [Roadmap](https://github.com/users/jrzaurin/projects/3) or [Open an issue](https://github.com/jrzaurin/pytorch-widedeep/issues) to report problems or recommend new features and submit a draft pull requests, which will be changed to pull request after intial review
44
- Contribute to the [tests](https://github.com/jrzaurin/pytorch-widedeep/tree/master/tests) to make it more reliable.
55
- Contribute to the [documentation](https://github.com/jrzaurin/pytorch-widedeep/tree/master/docs) to make it clearer for everyone.
66
- Contribute to the [examples](https://github.com/jrzaurin/pytorch-widedeep/tree/master/examples) to share your experience with other users.

README.md

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,15 @@ text and images using Wide and Deep models in Pytorch
2828

2929
The content of this document is organized as follows:
3030

31-
1. [introduction](#introduction)
32-
2. [The deeptabular component](#the-deeptabular-component)
33-
3. [installation](#installation)
34-
4. [quick start (tl;dr)](#quick-start)
31+
- [pytorch-widedeep](#pytorch-widedeep)
32+
- [Introduction](#introduction)
33+
- [The ``deeptabular`` component](#the-deeptabular-component)
34+
- [Installation](#installation)
35+
- [Developer Install](#developer-install)
36+
- [Quick start](#quick-start)
37+
- [Testing](#testing)
38+
- [How to Contribute](#how-to-contribute)
39+
- [Acknowledgments](#acknowledgments)
3540

3641
### Introduction
3742

@@ -75,9 +80,10 @@ without a ``deephead`` component can be formulated as:
7580
</p>
7681

7782

78-
Where *'W'* are the weight matrices applied to the wide model and to the final
79-
activations of the deep models, *'a'* are these final activations, and
80-
&phi;(x) are the cross product transformations of the original features *'x'*.
83+
Where &sigma; is the sigmoid function, *'W'* are the weight matrices applied to the wide model and to the final
84+
activations of the deep models, *'a'* are these final activations,
85+
&phi;(x) are the cross product transformations of the original features *'x'*, and
86+
, and *'b'* is the bias term.
8187
In case you are wondering what are *"cross product transformations"*, here is
8288
a quote taken directly from the paper: *"For binary features, a cross-product
8389
transformation (e.g., “AND(gender=female, language=en)”) is 1 if and only if
@@ -296,7 +302,7 @@ pytest tests
296302

297303
### How to Contribute
298304

299-
Check [CONTRIBUTING](https://github.com/jrzaurin/pytorch-widedeep/CONTRIBUTING.MD) page.
305+
Check [CONTRIBUTING](https://github.com/jrzaurin/pytorch-widedeep/blob/master/CONTRIBUTING.MD) page.
300306

301307
### Acknowledgments
302308

mkdocs/sources/contributing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pytorch-widedeep is being developed and used by many active community members. Your help is very valuable to make it better for everyone.
22

3-
- **[TBA]** Check for the [Roadmap](https://github.com/jrzaurin/pytorch-widedeep/projects/1) or [Open an issue](https://github.com/microsoft/jrzaurin/pytorch-widedeep/issues) to report problems or recommend new features and submit a draft pull requests, which will be changed to pull request after intial review
3+
- Check for the [Roadmap](https://github.com/users/jrzaurin/projects/3) or [Open an issue](https://github.com/jrzaurin/pytorch-widedeep/issues) to report problems or recommend new features and submit a draft pull requests, which will be changed to pull request after intial review
44
- Contribute to the [tests](https://github.com/jrzaurin/pytorch-widedeep/tree/master/tests) to make it more reliable.
55
- Contribute to the [documentation](https://github.com/jrzaurin/pytorch-widedeep/tree/master/docs) to make it clearer for everyone.
66
- Contribute to the [examples](https://github.com/jrzaurin/pytorch-widedeep/tree/master/examples) to share your experience with other users.

mkdocs/sources/index.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ Pytorch
2929

3030
The content of this document is organized as follows:
3131

32-
- [pytorch-widedeep](#pytorch-widedeep)
32+
- [**pytorch-widedeep**](#pytorch-widedeep)
3333
- [Introduction](#introduction)
34-
- [The deeptabular component](#the-deeptabular-component)
34+
- [The ``deeptabular`` component](#the-deeptabular-component)
3535
- [Acknowledgments](#acknowledgments)
3636

3737
### Introduction
@@ -75,9 +75,10 @@ $$
7575

7676

7777

78-
Where $W$ are the weight matrices applied to the wide model and to the final
79-
activations of the deep models, $a$ are these final activations, and
80-
$\phi(x)$ are the cross product transformations of the original features $x$.
78+
Where &sigma; is the sigmoid function, *'W'* are the weight matrices applied to the wide model and to the final
79+
activations of the deep models, *'a'* are these final activations,
80+
&phi;(x) are the cross product transformations of the original features *'x'*, and
81+
, and *'b'* is the bias term.
8182
In case you are wondering what are *"cross product transformations"*, here is
8283
a quote taken directly from the paper: *"For binary features, a cross-product
8384
transformation (e.g., “AND(gender=female, language=en)”) is 1 if and only if

0 commit comments

Comments
 (0)