Skip to content

Commit 788b9ba

Browse files
committed
fix: changed pagination for enveloped response
1 parent 57f6b88 commit 788b9ba

File tree

17 files changed

+148
-67
lines changed

17 files changed

+148
-67
lines changed

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,10 @@ The main differences to the @js-entity-repos/express:
1515

1616
- different naming convention: using `item` instead of `entity`
1717
- cursor based pagination operates using `before` and `after` instead of `cursor` and `direction`
18-
- optional `enveloping` response (`GET /endpoint?envelope=true`) for clients not capable of working with headers and JSONP
1918
- `granular transactions handlers` for each `request handler` - this could be used for i.e. `authentication` or `permissions` checks
2019
- possibility to `override` each `request handler`
2120
- ability to disable json body parser middleware if already present in the stack (`enableJsonBodyParser: false`)
2221
- by default all responses are `pretty` which improves readability, you can disable that by query param (`/endpoint?pretty=false`)
23-
- dropped support for `/count` endpoint, instead allows client to get number of available items by adding query param (`/endpoint?total=true` for get request, resulting in additional header: `x-total-count` which name is configurable)
2422

2523
## Installation:
2624

assets/jscpd-badge.svg

Lines changed: 2 additions & 2 deletions
Loading

dist/FacadeConfig.d.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,16 @@ import TransactionHandler from './types/TransactionHandler';
88
export default interface FacadeConfig<I extends Item> {
99
readonly dataKeyName: string;
1010
readonly totalHeaderName: string;
11-
readonly beforeHeaderName: string;
1211
readonly hasAfterHeaderName: string;
13-
readonly hasBeforeHeaderName: string;
1412
readonly afterHeaderName: string;
13+
readonly hasBeforeHeaderName: string;
14+
readonly beforeHeaderName: string;
15+
readonly paginationKey: string;
16+
readonly afterKey: string;
17+
readonly beforeKey: string;
18+
readonly hasBeforeKey: string;
19+
readonly hasAfterKey: string;
20+
readonly totalKey: string;
1521
readonly envelopeParamName: string;
1622
readonly prettyParamName: string;
1723
readonly createFilter: CreateFilter<I>;

dist/FactoryConfig.d.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ export default interface FactoryConfig<I extends Item> {
1414
readonly afterHeaderName?: string;
1515
readonly hasBeforeHeaderName?: string;
1616
readonly beforeHeaderName?: string;
17+
readonly afterKey?: string;
18+
readonly beforeKey?: string;
19+
readonly hasBeforeKey?: string;
20+
readonly hasAfterKey?: string;
21+
readonly totalKey?: string;
22+
readonly paginationKey?: string;
1723
readonly envelopParamName?: string;
1824
readonly prettyParamName?: string;
1925
readonly createFilter?: CreateFilter<I>;

dist/factory.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Item } from '@js-items/foundation';
22
import { Router } from 'express';
33
import FactoryConfig from './FactoryConfig';
4-
declare const _default: <I extends Item>({ deleteItem, deleteItems, getItem, getItems, updateItem, replaceItem, createItem, totalHeaderName, hasAfterHeaderName, afterHeaderName, hasBeforeHeaderName, beforeHeaderName, envelopParamName, prettyParamName, dataKeyName, ...config }: FactoryConfig<I>) => Router;
4+
declare const _default: <I extends Item>({ deleteItem, deleteItems, getItem, getItems, updateItem, replaceItem, createItem, totalHeaderName, hasAfterHeaderName, afterHeaderName, hasBeforeHeaderName, beforeHeaderName, afterKey, beforeKey, hasBeforeKey, hasAfterKey, totalKey, paginationKey, envelopParamName, prettyParamName, dataKeyName, ...config }: FactoryConfig<I>) => Router;
55
export default _default;

dist/factory.js

Lines changed: 10 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/factory.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)