Skip to content

Commit 23e0db0

Browse files
committed
fix broken build
1 parent 194525e commit 23e0db0

File tree

10 files changed

+94
-12
lines changed

10 files changed

+94
-12
lines changed

dist/functions/deleteItem/index.spec.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/functions/deleteItem/index.spec.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/utils/formatItemsResponse/index.js

Lines changed: 16 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/utils/formatItemsResponse/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/utils/formatItemsResponse/index.spec.js

Lines changed: 35 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/utils/formatItemsResponse/index.spec.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
},
3030
"homepage": "https://github.com/js-items/ky#readme",
3131
"devDependencies": {
32-
"@js-items/foundation": "1.0.27",
32+
"@js-items/foundation": "1.0.28",
3333
"@kube-js/semantic-release": "1.0.7",
3434
"@kube-js/tscommons": "1.0.5",
3535
"@types/jest": "24.0.18",

src/utils/formatItemsResponse/index.spec.ts

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,41 @@ describe('@formatItemsResponse', () => {
3232
});
3333

3434
const expectedResult = {
35-
cursor: pagination,
35+
cursor: { ...pagination },
3636
items: [testItem],
3737
};
3838

3939
expect(result).toEqual(expectedResult);
4040
});
4141

42+
it('gets response when envelope is set to false and there is not data', () => {
43+
const paginationData = {
44+
after: null,
45+
before: null,
46+
hasAfter: false,
47+
hasBefore: false,
48+
totalCount: 0,
49+
};
50+
51+
const response: PaginatedResponse<TestItem> = {
52+
data: [],
53+
pagination: paginationData,
54+
};
55+
56+
const result = formatItemResponse<TestItem>({
57+
config,
58+
envelope: false,
59+
response,
60+
});
61+
62+
const expectedResult = {
63+
cursor: { ...pagination, before: undefined, after: undefined, totalCount: 0 },
64+
items: [],
65+
};
66+
67+
expect(result).toEqual(expectedResult);
68+
});
69+
4270
it('gets response when envelope is set to true', () => {
4371
const envelopedResponse: EnvelopedResponse<PaginatedResponse<TestItem>> = {
4472
body: {

src/utils/formatItemsResponse/index.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
PaginatedResponse,
77
} from '@js-items/foundation';
88
import { Result } from '@js-items/foundation/dist/functions/GetItems';
9+
import _defaultTo from 'ramda/src/defaultTo';
910
import FacadeConfig from '../../FacadeConfig';
1011

1112
export interface Options<I extends Item> {
@@ -26,7 +27,11 @@ const formatItemsResponse = <I extends Item>({
2627
: (response as PaginatedResponse<I>);
2728

2829
return {
29-
cursor: pagination,
30+
cursor: {
31+
...pagination,
32+
after: _defaultTo(undefined)(pagination.after),
33+
before: _defaultTo(undefined)(pagination.before),
34+
},
3035
items: data.map(convertDocumentIntoItem),
3136
};
3237
};

0 commit comments

Comments
 (0)