Merge pull request #15 from js-items/develop

fix: fixes ky instance bug and refactored tests

Author: mariocoski

assets/jscpd-badge.svg

@@ -1,5 +1,4 @@
-import { CreateItem, DeleteItems, Filter, GetItem, GetItems, Item, ReplaceItem, Sort, UpdateItem } from '@js-items/foundation';
-import Facade from '@js-items/foundation/dist/Facade';
+import { CreateItem, DeleteItem, DeleteItems, Filter, GetItem, GetItems, Item, ReplaceItem, Sort, UpdateItem } from '@js-items/foundation';
 import ky from 'ky';
 import { ConvertItemIntoOptions } from './types/convertItemIntoOptions';
 import { Handler } from './types/handler';
@@ -19,23 +18,23 @@ export default interface FactoryConfig<I extends Item> {
     readonly paginationKey?: string;
     readonly envelopParamName?: string;
     readonly prettyParamName?: string;
-    readonly createFilter: (filter?: Filter<I>) => any;
-    readonly convertDocumentIntoItem: (document: Document) => I;
-    readonly convertItemIntoOptions: ConvertItemIntoOptions<I>;
-    readonly createSort: (sort: Sort<I>) => any;
+    readonly createFilter?: (filter?: Filter<I>) => any;
+    readonly convertDocumentIntoItem?: (document: Document) => I;
+    readonly convertItemIntoOptions?: ConvertItemIntoOptions<I>;
+    readonly createSort?: (sort: Sort<I>) => any;
     readonly updateItem?: Handler<I, UpdateItem<I>>;
     readonly updateItemOptions?: ConvertItemIntoOptions<I>;
     readonly replaceItem?: Handler<I, ReplaceItem<I>>;
     readonly replaceItemOptions?: ConvertItemIntoOptions<I>;
-    readonly deleteItem?: Handler<I, DeleteItems<I>>;
+    readonly deleteItem?: Handler<I, DeleteItem<I>>;
     readonly deleteItemOptions?: ConvertItemIntoOptions<I>;
-    readonly deleteItems?: Handler<I, CreateItem<I>>;
+    readonly deleteItems?: Handler<I, DeleteItems<I>>;
     readonly deleteItemsOptions?: ConvertItemIntoOptions<I>;
     readonly getItem?: Handler<I, GetItem<I>>;
     readonly getItemOptions?: ConvertItemIntoOptions<I>;
     readonly getItems?: Handler<I, GetItems<I>>;
     readonly getItemsOptions?: ConvertItemIntoOptions<I>;
-    readonly createItem?: Handler<I, ReplaceItem<I>>;
+    readonly createItem?: Handler<I, CreateItem<I>>;
     readonly createItemOptions?: ConvertItemIntoOptions<I>;
     readonly defaultPaginationLimit?: number;
     readonly itemName: string;

dist/FactoryConfig.d.ts

@@ -1,4 +1,5 @@
-import { /* DeleteItem, */ Item } from '@js-items/foundation';
+import { Item } from '@js-items/foundation';
+import Facade from '@js-items/foundation/dist/Facade';
 import FactoryConfig from './FactoryConfig';
-declare const _default: <I extends Item>({ deleteItem, deleteItems, getItem, getItems, updateItem, replaceItem, createItem, convertItemIntoOptions, ...config }: FactoryConfig<I>) => any;
-export default _default;
+declare const factory: <I extends Item>({ deleteItem, deleteItems, getItem, getItems, updateItem, replaceItem, createItem, convertItemIntoOptions, ...config }: FactoryConfig<I>) => Facade<I>;
+export default factory;