Fix inconsistency in order of observable operations

Previously, the monthDayFromFields() method of non-ISO calendars behaved
differently from dateFromFields() and yearMonthFromFields(), as well as
monthDayFromFields() of the ISO calendar. The latter checked the overflow
option before accessing the fields, and the former checked the overflow
option afterwards.

This normative change fixes this inconsistency. The general principle is
that arguments to a function should be validated in order, so we go with
accessing the fields before checking the overflow option.

Requires an update to the reference code, which previously consistently
checked the overflow option first.

UPSTREAM_COMMIT=a3a82377045895940f1278b19edfc9ae2e62e136

Author: ptomato

lib/calendar.ts

@@ -353,24 +353,24 @@ DefineIntrinsic('Temporal.Calendar.from', Calendar.from);
  */
 impl['iso8601'] = {
   dateFromFields(fieldsParam, options, calendar) {
-    const overflow = ES.ToTemporalOverflow(options);
     let fields = ES.PrepareTemporalFields(fieldsParam, ['day', 'month', 'monthCode', 'year'], ['year', 'day']);
+    const overflow = ES.ToTemporalOverflow(options);
     fields = resolveNonLunisolarMonth(fields);
     let { year, month, day } = fields;
     ({ year, month, day } = ES.RegulateISODate(year, month, day, overflow));
     return ES.CreateTemporalDate(year, month, day, calendar);
   },
   yearMonthFromFields(fieldsParam, options, calendar) {
-    const overflow = ES.ToTemporalOverflow(options);
     let fields = ES.PrepareTemporalFields(fieldsParam, ['month', 'monthCode', 'year'], ['year']);
+    const overflow = ES.ToTemporalOverflow(options);
     fields = resolveNonLunisolarMonth(fields);
     let { year, month } = fields;
     ({ year, month } = ES.RegulateISOYearMonth(year, month, overflow));
     return ES.CreateTemporalYearMonth(year, month, calendar, /* referenceISODay = */ 1);
   },
   monthDayFromFields(fieldsParam, options, calendar) {
-    const overflow = ES.ToTemporalOverflow(options);
     let fields = ES.PrepareTemporalFields(fieldsParam, ['day', 'month', 'monthCode', 'year'], ['day']);
+    const overflow = ES.ToTemporalOverflow(options);
     if (fields.month !== undefined && fields.year === undefined && fields.monthCode === undefined) {
       throw new TypeError('either year or monthCode required with month');
     }
@@ -2287,11 +2287,11 @@ class NonIsoCalendar implements CalendarImpl {
     options: NonNullable<Params['dateFromFields'][1]>,
     calendar: Temporal.Calendar
   ): Temporal.PlainDate {
-    const overflow = ES.ToTemporalOverflow(options);
     const cache = new OneObjectCache();
     const fieldNames = this.fields(['day', 'month', 'monthCode', 'year']) as readonly AnyTemporalKey[];
     ArrayPrototypeSort.call(fieldNames);
     const fields = ES.PrepareTemporalFields(fieldsParam, fieldNames, []);
+    const overflow = ES.ToTemporalOverflow(options);
     const { year, month, day } = this.helper.calendarToIsoDate(fields, overflow, cache);
     const result = ES.CreateTemporalDate(year, month, day, calendar);
     cache.setObject(result);
@@ -2302,11 +2302,11 @@ class NonIsoCalendar implements CalendarImpl {
     options: NonNullable<Params['yearMonthFromFields'][1]>,
     calendar: Temporal.Calendar
   ): Temporal.PlainYearMonth {
-    const overflow = ES.ToTemporalOverflow(options);
     const cache = new OneObjectCache();
     const fieldNames = this.fields(['month', 'monthCode', 'year']) as readonly AnyTemporalKey[];
     ArrayPrototypeSort.call(fieldNames);
     const fields = ES.PrepareTemporalFields(fieldsParam, fieldNames, []);
+    const overflow = ES.ToTemporalOverflow(options);
     const { year, month, day } = this.helper.calendarToIsoDate({ ...fields, day: 1 }, overflow, cache);
     const result = ES.CreateTemporalYearMonth(year, month, calendar, /* referenceISODay = */ day);
     cache.setObject(result);
@@ -2317,13 +2317,13 @@ class NonIsoCalendar implements CalendarImpl {
     options: NonNullable<Params['monthDayFromFields'][1]>,
     calendar: Temporal.Calendar
   ): Temporal.PlainMonthDay {
-    const overflow = ES.ToTemporalOverflow(options);
     const cache = new OneObjectCache();
     // For lunisolar calendars, either `monthCode` or `year` must be provided
     // because `month` is ambiguous without a year or a code.
     const fieldNames = this.fields(['day', 'month', 'monthCode', 'year']) as readonly AnyTemporalKey[];
     ArrayPrototypeSort.call(fieldNames);
     const fields = ES.PrepareTemporalFields(fieldsParam, fieldNames, []);
+    const overflow = ES.ToTemporalOverflow(options);
     const { year, month, day } = this.helper.monthDayFromFields(fields, overflow, cache);
     // `year` is a reference year where this month/day exists in this calendar
     const result = ES.CreateTemporalMonthDay(month, day, calendar, /* referenceISOYear = */ year);

test/expected-failures-todo-migrated-code.txt

@@ -13,7 +13,6 @@ built-ins/Temporal/Calendar/prototype/dateAdd/argument-string-time-zone-annotati
 built-ins/Temporal/Calendar/prototype/dateAdd/argument-string-unknown-annotation.js
 built-ins/Temporal/Calendar/prototype/dateAdd/argument-zoneddatetime-timezone-getoffsetnanosecondsfor-out-of-range.js
 built-ins/Temporal/Calendar/prototype/dateAdd/order-of-operations.js
-built-ins/Temporal/Calendar/prototype/dateFromFields/order-of-operations.js
 built-ins/Temporal/Calendar/prototype/dateUntil/argument-calendar-fields-undefined.js
 built-ins/Temporal/Calendar/prototype/dateUntil/argument-propertybag-calendar-instance-does-not-get-calendar-property.js
 built-ins/Temporal/Calendar/prototype/dateUntil/argument-propertybag-calendar-wrong-type.js
@@ -98,7 +97,6 @@ built-ins/Temporal/Calendar/prototype/monthCode/argument-string-date-with-utc-of
 built-ins/Temporal/Calendar/prototype/monthCode/argument-string-time-zone-annotation.js
 built-ins/Temporal/Calendar/prototype/monthCode/argument-string-unknown-annotation.js
 built-ins/Temporal/Calendar/prototype/monthCode/argument-zoneddatetime-timezone-getoffsetnanosecondsfor-out-of-range.js
-built-ins/Temporal/Calendar/prototype/monthDayFromFields/order-of-operations.js
 built-ins/Temporal/Calendar/prototype/monthsInYear/argument-calendar-fields-undefined.js
 built-ins/Temporal/Calendar/prototype/monthsInYear/argument-propertybag-calendar-case-insensitive.js
 built-ins/Temporal/Calendar/prototype/monthsInYear/argument-propertybag-calendar-instance-does-not-get-calendar-property.js
@@ -123,7 +121,6 @@ built-ins/Temporal/Calendar/prototype/year/argument-string-date-with-utc-offset.
 built-ins/Temporal/Calendar/prototype/year/argument-string-time-zone-annotation.js
 built-ins/Temporal/Calendar/prototype/year/argument-string-unknown-annotation.js
 built-ins/Temporal/Calendar/prototype/year/argument-zoneddatetime-timezone-getoffsetnanosecondsfor-out-of-range.js
-built-ins/Temporal/Calendar/prototype/yearMonthFromFields/order-of-operations.js
 built-ins/Temporal/Calendar/prototype/yearOfWeek/argument-calendar-datefromfields-called-with-null-prototype-fields.js
 built-ins/Temporal/Calendar/prototype/yearOfWeek/argument-calendar-fields-undefined.js
 built-ins/Temporal/Calendar/prototype/yearOfWeek/argument-leap-second.js
@@ -870,7 +867,6 @@ built-ins/Temporal/ZonedDateTime/prototype/yearOfWeek/validate-calendar-value.js
 built-ins/Temporal/ZonedDateTime/timezone-instance-does-not-get-timeZone-property.js
 intl402/Temporal/Calendar/calendar-case-insensitive.js
 intl402/Temporal/Calendar/from/calendar-case-insensitive.js
-intl402/Temporal/Calendar/prototype/dateFromFields/order-of-operations.js
 intl402/Temporal/Calendar/prototype/era/argument-calendar-fields-undefined.js
 intl402/Temporal/Calendar/prototype/era/argument-propertybag-calendar-case-insensitive.js
 intl402/Temporal/Calendar/prototype/era/argument-propertybag-calendar-instance-does-not-get-calendar-property.js
@@ -887,8 +883,6 @@ intl402/Temporal/Calendar/prototype/eraYear/argument-string-date-with-utc-offset
 intl402/Temporal/Calendar/prototype/eraYear/argument-string-time-zone-annotation.js
 intl402/Temporal/Calendar/prototype/eraYear/argument-string-unknown-annotation.js
 intl402/Temporal/Calendar/prototype/eraYear/argument-zoneddatetime-timezone-getoffsetnanosecondsfor-out-of-range.js
-intl402/Temporal/Calendar/prototype/monthDayFromFields/order-of-operations.js
-intl402/Temporal/Calendar/prototype/yearMonthFromFields/order-of-operations.js
 intl402/Temporal/Calendar/prototype/yearOfWeek/infinity-throws-rangeerror.js
 intl402/Temporal/TimeZone/prototype/getNextTransition/transition-at-instant-boundaries.js
 intl402/Temporal/TimeZone/prototype/getPreviousTransition/transition-at-instant-boundaries.js