Skip to content

Commit 3145c6c

Browse files
committed
Fix Calendar.fields return type to match the spec
Port of tc39/proposal-temporal#2056
1 parent f2e2658 commit 3145c6c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

index.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -746,7 +746,7 @@ export namespace Temporal {
746746
two: Temporal.PlainDate | PlainDateLike | string,
747747
options?: DifferenceOptions<'year' | 'month' | 'week' | 'day'>
748748
): Temporal.Duration;
749-
fields(fields: Iterable<string>): Iterable<string>;
749+
fields(fields: Iterable<string>): string[];
750750
mergeFields(fields: Record<string, unknown>, additionalFields: Record<string, unknown>): Record<string, unknown>;
751751
toString(): string;
752752
toJSON(): string;
@@ -1340,7 +1340,7 @@ export namespace Temporal {
13401340
* a more ergonomic alternative to this method is
13411341
* `Temporal.Now.zonedDateTimeISO()`.
13421342
*
1343-
* @param {Temporal.Calendar | string} [calendar] - calendar identifier, or
1343+
* @param {CalendarLike} [calendar] - calendar identifier, or
13441344
* a `Temporal.Calendar` instance, or an object implementing the calendar
13451345
* protocol.
13461346
* @param {TimeZoneLike} [tzLike] -
@@ -1377,7 +1377,7 @@ export namespace Temporal {
13771377
* `Temporal.Now.zonedDateTimeISO` or `Temporal.Now.zonedDateTime` instead
13781378
* of this function.
13791379
*
1380-
* @param {Temporal.Calendar | string} [calendar] - calendar identifier, or
1380+
* @param {CalendarLike} [calendar] - calendar identifier, or
13811381
* a `Temporal.Calendar` instance, or an object implementing the calendar
13821382
* protocol.
13831383
* @param {TimeZoneLike} [tzLike] -

lib/calendar.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ interface CalendarImpl {
9292
two: Temporal.PlainDate,
9393
largestUnit: 'year' | 'month' | 'week' | 'day'
9494
): { years: number; months: number; weeks: number; days: number };
95-
fields(fields: Iterable<string>): Iterable<string>;
95+
fields(fields: string[]): string[];
9696
mergeFields(fields: Record<string, unknown>, additionalFields: Record<string, unknown>): Record<string, unknown>;
9797
}
9898

0 commit comments

Comments
 (0)