Fixed Duration.prototype.total() return value

UPSTREAM_COMMIT=10e0ab3b4d300adba956ed0001289ac515e67951

Author: Aditi-1400

lib/duration.ts

@@ -344,7 +344,7 @@ export class Duration implements Temporal.Duration {
     if (ES.IsTemporalZonedDateTime(relativeTo)) {
       intermediate = ES.MoveRelativeZonedDateTime(relativeTo, years, months, weeks, 0);
     }
-    ({ days, hours, minutes, seconds, milliseconds, microseconds, nanoseconds } = ES.BalanceDuration(
+    let balanceResult = ES.BalancePossiblyInfiniteDuration(
       days,
       hours,
       minutes,
@@ -354,7 +354,13 @@ export class Duration implements Temporal.Duration {
       nanoseconds,
       unit,
       intermediate
-    ));
+    );
+    if (balanceResult === 'positive overflow') {
+      return Infinity;
+    } else if (balanceResult === 'negative overflow') {
+      return -Infinity;
+    }
+    ({ days, hours, minutes, seconds, milliseconds, microseconds, nanoseconds } = balanceResult);
     // Finally, truncate to the correct unit and calculate remainder
     const { total } = ES.RoundDuration(
       years,

lib/ecmascript.ts

@@ -3422,6 +3422,35 @@ export function BalanceDuration(
   nanosecondsParam: number,
   largestUnit: Temporal.DateTimeUnit,
   relativeTo: ReturnType<typeof ToRelativeTemporalObject> = undefined
+) {
+  let result = BalancePossiblyInfiniteDuration(
+    daysParam,
+    hoursParam,
+    minutesParam,
+    secondsParam,
+    millisecondsParam,
+    microsecondsParam,
+    nanosecondsParam,
+    largestUnit,
+    relativeTo
+  );
+  if (result === 'positive overflow' || result === 'negative overflow') {
+    throw new RangeError('Duration out of range');
+  } else {
+    return result;
+  }
+}
+
+export function BalancePossiblyInfiniteDuration(
+  daysParam: number,
+  hoursParam: number,
+  minutesParam: number,
+  secondsParam: number,
+  millisecondsParam: number,
+  microsecondsParam: number,
+  nanosecondsParam: number,
+  largestUnit: Temporal.DateTimeUnit,
+  relativeTo: ReturnType<typeof ToRelativeTemporalObject> = undefined
 ) {
   let days = daysParam;
   let nanosecondsBigInt: JSBI,
@@ -3513,6 +3542,16 @@ export function BalanceDuration(
   const microseconds = JSBI.toNumber(microsecondsBigInt) * sign;
   const nanoseconds = JSBI.toNumber(nanosecondsBigInt) * sign;
 
+  for (const prop of [days, hours, minutes, seconds, milliseconds, microseconds, nanoseconds]) {
+    if (!NumberIsFinite(prop)) {
+      if (sign === 1) {
+        return 'positive overflow' as const;
+      } else {
+        return 'negative overflow' as const;
+      }
+    }
+  }
+
   return { days, hours, minutes, seconds, milliseconds, microseconds, nanoseconds };
 }
 

test/expected-failures-todo-migrated-code.txt

@@ -224,7 +224,6 @@ built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-timezone-inst
 built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-timezone-wrong-type.js
 built-ins/Temporal/Duration/prototype/total/relativeto-string-datetime.js
 built-ins/Temporal/Duration/prototype/total/relativeto-zoneddatetime-timezone-getoffsetnanosecondsfor-out-of-range.js
-built-ins/Temporal/Duration/prototype/total/total-value-infinity.js
 built-ins/Temporal/Instant/compare/argument-string-calendar-annotation.js
 built-ins/Temporal/Instant/compare/argument-string-date-with-utc-offset.js
 built-ins/Temporal/Instant/compare/argument-string-time-zone-annotation.js