Skip to content

Commit 79624c2

Browse files
ptomatojustingrant
authored andcommitted
Polyfill: Remove redundant bigInteger abs()
If we are comparing to zero, there's no need to take the absolute value. The bigInteger library, like BigInt, doesn't distinguish -0. No spec change needed. The spec text does not specify abs() here. UPSTREAM_COMMIT=d3c12eac0899d69b8d19efd3a6a8750de43bad53
1 parent c50801d commit 79624c2

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

lib/ecmascript.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4021,7 +4021,7 @@ export function UnbalanceDurationRelative(
40214021
dateAdd = GetMethod(calendar, 'dateAdd');
40224022
dateUntil = GetMethod(calendar, 'dateUntil');
40234023
}
4024-
while (!isZero(abs(years))) {
4024+
while (!isZero(years)) {
40254025
const newRelativeTo = CalendarDateAdd(calendar, relativeTo, oneYear, undefined, dateAdd);
40264026
const untilOptions = ObjectCreate(null) as Temporal.DifferenceOptions<typeof largestUnit>;
40274027
untilOptions.largestUnit = 'month';
@@ -4038,15 +4038,15 @@ export function UnbalanceDurationRelative(
40384038
assertExists(relativeTo);
40394039
const dateAdd = typeof calendar !== 'string' ? GetMethod(calendar, 'dateAdd') : undefined;
40404040
// balance years down to days
4041-
while (!isZero(abs(years))) {
4041+
while (!isZero(years)) {
40424042
let oneYearDays;
40434043
({ relativeTo, days: oneYearDays } = MoveRelativeDate(calendar, relativeTo, oneYear, dateAdd));
40444044
days = JSBI.add(days, JSBI.BigInt(oneYearDays));
40454045
years = JSBI.subtract(years, signBI);
40464046
}
40474047

40484048
// balance months down to days
4049-
while (!isZero(abs(months))) {
4049+
while (!isZero(months)) {
40504050
let oneMonthDays;
40514051
({ relativeTo, days: oneMonthDays } = MoveRelativeDate(calendar, relativeTo, oneMonth, dateAdd));
40524052
days = JSBI.add(days, JSBI.BigInt(oneMonthDays));
@@ -4059,7 +4059,7 @@ export function UnbalanceDurationRelative(
40594059
if (isZero(years) && isZero(months) && isZero(weeks)) break;
40604060
if (!calendar) throw new RangeError('a starting point is required for balancing calendar units');
40614061
const dateAdd = typeof calendar !== 'string' ? GetMethod(calendar, 'dateAdd') : undefined;
4062-
while (!isZero(abs(years))) {
4062+
while (!isZero(years)) {
40634063
assertExists(relativeTo);
40644064
let oneYearDays;
40654065
({ relativeTo, days: oneYearDays } = MoveRelativeDate(calendar, relativeTo, oneYear, dateAdd));
@@ -4068,7 +4068,7 @@ export function UnbalanceDurationRelative(
40684068
}
40694069

40704070
// balance months down to days
4071-
while (!isZero(abs(months))) {
4071+
while (!isZero(months)) {
40724072
assertExists(relativeTo);
40734073
let oneMonthDays;
40744074
({ relativeTo, days: oneMonthDays } = MoveRelativeDate(calendar, relativeTo, oneMonth, dateAdd));
@@ -4077,7 +4077,7 @@ export function UnbalanceDurationRelative(
40774077
}
40784078

40794079
// balance weeks down to days
4080-
while (!isZero(abs(weeks))) {
4080+
while (!isZero(weeks)) {
40814081
assertExists(relativeTo);
40824082
let oneWeekDays;
40834083
({ relativeTo, days: oneWeekDays } = MoveRelativeDate(calendar, relativeTo, oneWeek, dateAdd));

0 commit comments

Comments
 (0)