Fix nonconformance bug with relativeTo property bag

ptomato · 12wrigja · commit 9992f9b1137f · 2022-07-06T11:58:48.000-07:00
Previously, a property bag such as { year: 2022, month: 4, day: 18,
timeZone: null } would be treated as a PlainDate relativeTo. According to
the spec text it should throw a TypeError.

Test262 tests for this are in review.

UPSTREAM_COMMIT=79c87efbb2d805eee519cfcc8a763d4f41193801
diff --git a/lib/ecmascript.ts b/lib/ecmascript.ts
@@ -1040,7 +1040,7 @@ export function ToRelativeTemporalObject(options: {
     calendar = ToTemporalCalendar(calendar);
     matchMinutes = true;
   }
-  if (timeZone) {
+  if (timeZone !== undefined) {
     timeZone = ToTemporalTimeZone(timeZone);
     let offsetNs = 0;
     if (offsetBehaviour === 'option') offsetNs = ParseTimeZoneOffsetString(ToString(offset));

Original file line number	Diff line number	Diff line change
`@@ -1040,7 +1040,7 @@ export function ToRelativeTemporalObject(options: {`
`1040`	`1040`	`calendar = ToTemporalCalendar(calendar);`
`1041`	`1041`	`matchMinutes = true;`
`1042`	`1042`	`}`
`1043`		`- if (timeZone) {`
	`1043`	`+ if (timeZone !== undefined) {`
`1044`	`1044`	`timeZone = ToTemporalTimeZone(timeZone);`
`1045`	`1045`	`let offsetNs = 0;`
`1046`	`1046`	`if (offsetBehaviour === 'option') offsetNs = ParseTimeZoneOffsetString(ToString(offset));`