BREAKING_CHANGE: modify throwOnError option work for queries and methods refetch and start (query), now with this flag(true) and using start\refetch user should catch error

Author: js2me

src/mobx-inifinite-query.ts

@@ -309,7 +309,20 @@ export class MobxInfiniteQuery<
   }
 
   async refetch(options?: RefetchOptions) {
-    return await this.queryObserver.refetch(options);
+    const result = await this.queryObserver.refetch(options);
+    const query = this.queryObserver.getCurrentQuery();
+
+    if (
+      query.state.error &&
+      (options?.throwOnError ||
+        this.options.throwOnError === true ||
+        (typeof this.options.throwOnError === 'function' &&
+          this.options.throwOnError(query.state.error, query)))
+    ) {
+      throw query.state.error;
+    }
+
+    return result;
   }
 
   async reset(params?: MobxInfiniteQueryResetParams) {

src/mobx-query.test.ts

@@ -1282,4 +1282,76 @@ describe('MobxQuery', () => {
       expect(getDynamicOptionsSpy).toBeCalledTimes(3);
     });
   });
+
+  describe('throwOnError', () => {
+    it('should throw error (throwOnError: true in options)', async () => {
+      vi.useFakeTimers();
+      const query = new MobxQueryMock({
+        throwOnError: true,
+        enabled: false,
+        queryFn: async () => {
+          throw new Error('MobxQueryError');
+        },
+      });
+      let error: Error | undefined;
+
+      const promise = query.start().catch((error_) => {
+        error = error_;
+      });
+      await vi.runAllTimersAsync();
+
+      await promise;
+
+      expect(error?.message).toBe('MobxQueryError');
+    });
+
+    it('should throw error (updating param throwOnError true)', async () => {
+      vi.useFakeTimers();
+      const query = new MobxQueryMock({
+        enabled: false,
+        queryFn: async () => {
+          throw new Error('MobxQueryError');
+        },
+      });
+      let error: Error | undefined;
+
+      const promise = query.start({ throwOnError: true }).catch((error_) => {
+        error = error_;
+      });
+      await vi.runAllTimersAsync();
+
+      await promise;
+
+      expect(error?.message).toBe('MobxQueryError');
+    });
+
+    it('should throw error (throwOnError: true in global options)', async () => {
+      vi.useFakeTimers();
+      const query = new MobxQueryMock(
+        {
+          enabled: false,
+          queryFn: async () => {
+            throw new Error('MobxQueryError');
+          },
+        },
+        new QueryClient({
+          defaultOptions: {
+            queries: {
+              throwOnError: true,
+            },
+          },
+        }),
+      );
+      let error: Error | undefined;
+
+      const promise = query.start().catch((error_) => {
+        error = error_;
+      });
+      await vi.runAllTimersAsync();
+
+      await promise;
+
+      expect(error?.message).toBe('MobxQueryError');
+    });
+  });
 });

src/mobx-query.ts

@@ -171,7 +171,20 @@ export class MobxQuery<
   }
 
   async refetch(options?: RefetchOptions) {
-    return await this.queryObserver.refetch(options);
+    const result = await this.queryObserver.refetch(options);
+    const query = this.queryObserver.getCurrentQuery();
+
+    if (
+      query.state.error &&
+      (options?.throwOnError ||
+        this.options.throwOnError === true ||
+        (typeof this.options.throwOnError === 'function' &&
+          this.options.throwOnError(query.state.error, query)))
+    ) {
+      throw query.state.error;
+    }
+
+    return result;
   }
 
   protected createQueryHash(
@@ -350,7 +363,8 @@ export class MobxQuery<
       ...params,
     };
     this.update(options);
-    return await this.refetch();
+
+    await this.refetch();
   }
 
   /**