fix: perf improvenment (redundand observable result update call)

Author: js2me

.changeset/sweet-facts-relax.md

@@ -0,0 +1,5 @@
+---
+"mobx-tanstack-query": patch
+---
+
+fix redundant updateResult observable call after initialize mutation/query

src/inifinite-query.ts

@@ -360,24 +360,6 @@ export class InfiniteQuery<
     };
     this.hooks = qc.hooks;
 
-    observable.deep(this, '_result');
-    observable.ref(this, 'isResultRequsted');
-    action.bound(this, 'setData');
-    action.bound(this, 'update');
-    action.bound(this, 'updateResult');
-    this.refetch = this.refetch.bind(this);
-    this.start = this.start.bind(this);
-
-    originalQueryProperties.forEach((property) => {
-      if (!this[property]) {
-        Object.defineProperty(this, property, {
-          get: () => this.result[property],
-        });
-      }
-    });
-
-    makeObservable(this);
-
     const isQueryKeyDynamic = typeof queryKeyOrDynamicQueryKey === 'function';
 
     if (!isQueryKeyDynamic) {
@@ -434,6 +416,24 @@ export class InfiniteQuery<
     // @ts-expect-error
     this.updateResult(this.queryObserver.getOptimisticResult(this.options));
 
+    observable.deep(this, '_result');
+    observable.ref(this, 'isResultRequsted');
+    action.bound(this, 'setData');
+    action.bound(this, 'update');
+    action.bound(this, 'updateResult');
+    this.refetch = this.refetch.bind(this);
+    this.start = this.start.bind(this);
+
+    originalQueryProperties.forEach((property) => {
+      if (!this[property]) {
+        Object.defineProperty(this, property, {
+          get: () => this.result[property],
+        });
+      }
+    });
+
+    makeObservable(this);
+
     if (this.features.lazy) {
       const cleanup = lazyObserve({
         context: this,

src/mutation.ts

@@ -182,19 +182,6 @@ export class Mutation<
     this.errorListeners = [];
     this.doneListeners = [];
 
-    observable.deep(this, 'result');
-    action.bound(this, 'updateResult');
-    this.mutate = this.mutate.bind(this);
-    this.start = this.start.bind(this);
-
-    originalMutationProperties.forEach((property) => {
-      Object.defineProperty(this, property, {
-        get: () => this.result[property],
-      });
-    });
-
-    makeObservable(this);
-
     this.mutationOptions = this.queryClient.defaultMutationOptions(restOptions);
 
     this.mutationObserver = new MutationObserver<
@@ -215,6 +202,19 @@ export class Mutation<
 
     this.updateResult(this.mutationObserver.getCurrentResult());
 
+    observable.deep(this, 'result');
+    action.bound(this, 'updateResult');
+    this.mutate = this.mutate.bind(this);
+    this.start = this.start.bind(this);
+
+    originalMutationProperties.forEach((property) => {
+      Object.defineProperty(this, property, {
+        get: () => this.result[property],
+      });
+    });
+
+    makeObservable(this);
+
     if (this.features.lazy) {
       const cleanup = lazyObserve({
         context: this,

src/query.ts

@@ -22,7 +22,6 @@ import {
   when,
 } from 'mobx';
 import { lazyObserve } from 'yummies/mobx';
-
 import { enableHolder } from './constants.js';
 import type {
   QueryConfig,
@@ -358,22 +357,6 @@ export class Query<
     };
     this.hooks = qc.hooks;
 
-    observable.deep(this, '_result');
-    observable.ref(this, 'isResultRequsted');
-    action.bound(this, 'setData');
-    action.bound(this, 'update');
-    action.bound(this, 'updateResult');
-    this.refetch = this.refetch.bind(this);
-    this.start = this.start.bind(this);
-
-    originalQueryProperties.forEach((property) => {
-      Object.defineProperty(this, property, {
-        get: () => this.result[property],
-      });
-    });
-
-    makeObservable(this);
-
     const isQueryKeyDynamic = typeof queryKeyOrDynamicQueryKey === 'function';
 
     if (!isQueryKeyDynamic) {
@@ -426,6 +409,22 @@ export class Query<
 
     this.updateResult(this.queryObserver.getOptimisticResult(this.options));
 
+    observable.deep(this, '_result');
+    observable.ref(this, 'isResultRequsted');
+    action.bound(this, 'setData');
+    action.bound(this, 'update');
+    action.bound(this, 'updateResult');
+    this.refetch = this.refetch.bind(this);
+    this.start = this.start.bind(this);
+
+    originalQueryProperties.forEach((property) => {
+      Object.defineProperty(this, property, {
+        get: () => this.result[property],
+      });
+    });
+
+    makeObservable(this);
+
     if (this.features.lazy) {
       const cleanup = lazyObserve({
         context: this,