Skip to content

Commit 769e879

Browse files
committed
chore: remove Disposable interface from 'implements'
1 parent 071dda0 commit 769e879

File tree

5 files changed

+25
-4
lines changed

5 files changed

+25
-4
lines changed

src/inifinite-query.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ export class InfiniteQuery<
8282
>
8383
extends Destroyable
8484
implements
85-
Disposable,
8685
Pick<
8786
InfiniteQueryObserverBaseResult<TData, TError>,
8887
(typeof originalQueryProperties)[number]

src/mutation.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ export class Mutation<
4747
>
4848
extends Destroyable
4949
implements
50-
Disposable,
5150
Pick<
5251
MutationObserverBaseResult<TData, TError, TVariables, TOnMutateResult>,
5352
(typeof originalMutationProperties)[number]

src/query.test.ts

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3873,5 +3873,29 @@ describe('Query', () => {
38733873
>();
38743874
expectTypeOf(userQueryResult.error).toEqualTypeOf<Error>();
38753875
}
3876+
3877+
if (userQuery.result.isSuccess) {
3878+
expectTypeOf(userQuery.result.data).toEqualTypeOf<{ email: string }>();
3879+
expectTypeOf(userQuery.result.error).toEqualTypeOf<null>();
3880+
}
3881+
3882+
if (userQuery.result.isError) {
3883+
expectTypeOf(userQuery.result.data).toEqualTypeOf<
3884+
{ email: string } | undefined
3885+
>();
3886+
expectTypeOf(userQuery.result.error).toEqualTypeOf<Error>();
3887+
}
3888+
3889+
// if (userQuery.isSuccess) {
3890+
// expectTypeOf(userQuery.data).toEqualTypeOf<{ email: string }>();
3891+
// expectTypeOf(userQuery.error).toEqualTypeOf<null>();
3892+
// }
3893+
3894+
// if (userQuery.isError) {
3895+
// expectTypeOf(userQuery.data).toEqualTypeOf<
3896+
// { email: string } | undefined
3897+
// >();
3898+
// expectTypeOf(userQuery.error).toEqualTypeOf<Error>();
3899+
// }
38763900
});
38773901
});

src/query.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ export class Query<
7373
>
7474
extends Destroyable
7575
implements
76-
Disposable,
7776
Pick<
7877
QueryObserverBaseResult<TData, TError>,
7978
(typeof originalQueryProperties)[number]

src/utils/destroyable.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { LinkedAbortController } from 'linked-abort-controller';
22
import { action, makeObservable } from 'mobx';
33

4-
export abstract class Destroyable {
4+
export abstract class Destroyable implements Disposable {
55
protected abortController: LinkedAbortController;
66

77
constructor(abortSignal?: AbortSignal) {

0 commit comments

Comments
 (0)