fix: bug with not reactive options #64

Author: js2me

.changeset/yellow-candles-invent.md

@@ -0,0 +1,5 @@
+---
+"mobx-tanstack-query": patch
+---
+
+fix bug with not reactive options in queries sometimes (#64)

src/inifinite-query.ts

@@ -470,6 +470,7 @@ export class InfiniteQuery<
         reaction(getAllDynamicOptions, this.update, {
           delay: this.config.dynamicOptionsUpdateDelay,
           signal: config.abortSignal,
+          fireImmediately: true,
           equals: this.features.dynamicOptionsComparer,
         });
       }

src/query.test.ts

@@ -31,7 +31,7 @@ import {
   vi,
 } from 'vitest';
 import { sleep } from 'yummies/async';
-
+import type { Maybe } from 'yummies/types';
 import { createQuery } from './preset/index.js';
 import { Query } from './query.js';
 import type {
@@ -3898,4 +3898,26 @@ describe('Query', () => {
     //   expectTypeOf(userQuery.error).toEqualTypeOf<Error>();
     // }
   });
+
+  it('bug #64 (options is not reactive sometimes)', () => {
+    const isEnabled = observable.box(false);
+    let query: Maybe<Query>;
+
+    const queryFn = vi.fn(() => Promise.resolve({ status: 'success' }));
+
+    runInAction(() => {
+      query = createQuery(queryFn, {
+        enableOnDemand: true,
+        options: () => ({
+          enabled: isEnabled.get(),
+        }),
+      });
+
+      isEnabled.set(true);
+    });
+
+    query?.result.data; // this won't trigger fetching, which is unexpected
+
+    expect(queryFn).toBeCalledTimes(1);
+  });
 });

src/query.ts

@@ -462,6 +462,7 @@ export class Query<
         reaction(getAllDynamicOptions, this.update, {
           delay: this.features.dynamicOptionsUpdateDelay,
           signal: config.abortSignal,
+          fireImmediately: true,
           equals: this.features.dynamicOptionsComparer,
         });
       }