Skip to content

Commit 994f059

Browse files
committed
fix: withViewModel overload with model and component only
1 parent 8a01e1c commit 994f059

File tree

2 files changed

+16
-14
lines changed

2 files changed

+16
-14
lines changed

.changeset/curvy-oranges-add.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"mobx-view-model": patch
3+
---
4+
5+
fix withViewModel overload typings

src/hoc/with-view-model.tsx

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -76,17 +76,10 @@ export type ComponentWithViewModel<
7676
) => ReactNode;
7777

7878
/**
79-
* Creates new instance of ViewModel
79+
* A Higher-Order Component that connects React components to their ViewModels, providing seamless MobX integration.
8080
*
8181
* [**Documentation**](https://js2me.github.io/mobx-view-model/react/api/with-view-model.html)
8282
*/
83-
export function withViewModel<TViewModel extends AnyViewModel>(
84-
model: Class<TViewModel>,
85-
config?: ViewModelHocConfig<TViewModel>,
86-
): <TComponentOriginProps extends AnyObject = ViewModelProps<TViewModel>>(
87-
Component?: ComponentType<TComponentOriginProps & ViewModelProps<TViewModel>>,
88-
) => ComponentWithViewModel<TViewModel, TComponentOriginProps>;
89-
9083
export function withViewModel<
9184
TViewModel extends AnyViewModel,
9285
TComponentOriginProps extends AnyObject = ViewModelProps<TViewModel>,
@@ -96,13 +89,17 @@ export function withViewModel<
9689
config?: ViewModelHocConfig<TViewModel>,
9790
): ComponentWithViewModel<TViewModel, TComponentOriginProps>;
9891

99-
export function withViewModel<
100-
TViewModel extends AnyViewModel,
101-
TComponentOriginProps extends AnyObject = ViewModelProps<TViewModel>,
102-
>(
92+
/**
93+
* A Higher-Order Component that connects React components to their ViewModels, providing seamless MobX integration.
94+
*
95+
* [**Documentation**](https://js2me.github.io/mobx-view-model/react/api/with-view-model.html)
96+
*/
97+
export function withViewModel<TViewModel extends AnyViewModel>(
10398
model: Class<TViewModel>,
104-
component: ComponentType<TComponentOriginProps & ViewModelProps<TViewModel>>,
105-
): ComponentWithViewModel<TViewModel, TComponentOriginProps>;
99+
config?: ViewModelHocConfig<TViewModel>,
100+
): <TComponentOriginProps extends AnyObject = ViewModelProps<TViewModel>>(
101+
Component?: ComponentType<TComponentOriginProps & ViewModelProps<TViewModel>>,
102+
) => ComponentWithViewModel<TViewModel, TComponentOriginProps>;
106103

107104
/**
108105
* Creates new instance of ViewModel

0 commit comments

Comments
 (0)