BREAKING_CHANGE: removed all depreactions: disposer, dispose, AbstractViewModelStore, AbstractViewModel, AbstractViewModelParams

Author: js2me

package.json

@@ -42,7 +42,6 @@
     "react-simple-loadable": "^1.0.0"
   },
   "peerDependencies": {
-    "disposer-util": "^1.0.9",
     "mobx": ">=6.12.4",
     "mobx-react-lite": ">=4.0.7",
     "react": ">=18.3.1"

pnpm-lock.yaml

@@ -1,8 +1,5 @@
 export * from './view-model';
-export * from './abstract-view-model';
-export * from './abstract-view-model.types';
 export * from './view-model.store';
-export * from './abstract-view-model.store';
 export * from './view-model.store.types';
 export * from './view-model.types';
 export * from './view-model.impl';

src/view-model/abstract-view-model.store.ts

@@ -1,5 +1,4 @@
 /* eslint-disable @typescript-eslint/no-unused-vars */
-import { Disposer, IDisposer } from 'disposer-util';
 import { isEqual } from 'lodash-es';
 import { action, computed, makeObservable, observable } from 'mobx';
 
@@ -20,11 +19,6 @@ export class ViewModelImpl<
 
   public unmountSignal: AbortSignal;
 
-  /**
-   * @deprecated Removed since 5.0.0. Please use {unmountSignal} instead
-   */
-  protected disposer: IDisposer = new Disposer();
-
   id: string;
 
   isMounted = false;
@@ -37,10 +31,6 @@ export class ViewModelImpl<
     this.abortController = new AbortController();
     this.unmountSignal = this.abortController.signal;
 
-    this.unmountSignal.addEventListener('abort', () => {
-      this.disposer.dispose();
-    });
-
     observable.ref(this, 'isMounted');
     computed(this, 'parentViewModel');
     observable.ref(this, 'payload');
@@ -133,11 +123,4 @@ export class ViewModelImpl<
       (this.viewModels?.get(parentViewModelId) as unknown as ParentViewModel)
     );
   }
-
-  /**
-   * @deprecated Removed since 5.0.0. Use {didUnmount} instead
-   */
-  dispose(): void {
-    this.abortController.abort();
-  }
 }

src/view-model/abstract-view-model.ts

@@ -2,15 +2,14 @@ import { describe, expect, it, vi } from 'vitest';
 
 import { AnyObject, EmptyObject, Maybe } from '../utils/types';
 
-import { AbstractViewModelParams } from './abstract-view-model.types';
 import { ViewModel } from './view-model';
 import { ViewModelMock } from './view-model.impl.test';
 import { ViewModelStore } from './view-model.store';
 import {
   ViewModelGenerateIdConfig,
   ViewModelLookup,
 } from './view-model.store.types';
-import { AnyViewModel } from './view-model.types';
+import { AnyViewModel, ViewModelParams } from './view-model.types';
 
 import { ViewModelStoreImpl } from '.';
 
@@ -59,10 +58,6 @@ describe('ViewModelStoreImpl', () => {
     const vmStore = new ViewModelStoreMock();
     expect(vmStore.clean).toBeDefined();
   });
-  it('has dispose method', () => {
-    const vmStore = new ViewModelStoreMock();
-    expect(vmStore.dispose).toBeDefined();
-  });
   it('has attach method', () => {
     const vmStore = new ViewModelStoreMock();
     expect(vmStore.attach).toBeDefined();
@@ -112,7 +107,7 @@ describe('ViewModelStoreImpl', () => {
     > extends ViewModelMock<Payload, ParentViewModel> {
       constructor(
         private vmStore: ViewModelStore,
-        params?: Partial<AbstractViewModelParams<Payload>>,
+        params?: Partial<ViewModelParams<Payload>>,
       ) {
         super(params);
       }

src/view-model/abstract-view-model.types.ts

@@ -232,11 +232,4 @@ export class ViewModelStoreImpl<VMBase extends AnyViewModel = AnyViewModel>
     this.mountingViews.clear();
     this.unmountingViews.clear();
   }
-
-  /**
-   * @deprecated Removed since 5.0.0. Use {clean} instead
-   */
-  dispose(): void {
-    this.clean();
-  }
 }

src/view-model/index.ts

@@ -105,9 +105,4 @@ export interface ViewModelStore<VMBase extends AnyViewModel = AnyViewModel>
   generateViewModelId<VM extends VMBase>(
     config: ViewModelGenerateIdConfig<VM>,
   ): string;
-
-  /**
-   * @deprecated Removed since 5.0.0. Use {clean} instead
-   */
-  dispose(): void;
 }