Skip to content

Commit 3170a02

Browse files
committed
fix: path params type
1 parent 985861d commit 3170a02

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

src/page-view-model/page-view-model.impl.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@ import { EmptyObject } from 'mobx-vm-entities/utils/types';
33
import { describe, expect, test } from 'vitest';
44

55
import { PageViewModelImpl } from './page-view-model.impl';
6+
import { AnyPathParams } from './page-view-model.types';
67

78
export class PageViewModelMock<
8-
Params extends Record<string, string> = EmptyObject,
9+
Params extends AnyPathParams = EmptyObject,
910
ParentViewModel extends AnyViewModel | null = null,
1011
> extends PageViewModelImpl<Params, ParentViewModel> {}
1112

src/page-view-model/page-view-model.impl.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@ import { AnyViewModel, ViewModelImpl } from 'mobx-vm-entities';
22
import { EmptyObject } from 'mobx-vm-entities/utils/types';
33

44
import { PageViewModel } from './page-view-model';
5+
import { AnyPathParams } from './page-view-model.types';
56

67
export class PageViewModelImpl<
7-
Params extends Record<string, string> = EmptyObject,
8+
Params extends AnyPathParams = EmptyObject,
89
ParentViewModel extends AnyViewModel | null = null,
910
>
1011
extends ViewModelImpl<Params, ParentViewModel>

src/page-view-model/page-view-model.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
import { AnyViewModel, ViewModel } from 'mobx-vm-entities';
22
import { EmptyObject } from 'mobx-vm-entities/utils/types';
33

4+
import { AnyPathParams } from './page-view-model.types';
5+
46
export interface PageViewModel<
5-
Params extends Record<string, string> = EmptyObject,
7+
Params extends AnyPathParams = EmptyObject,
68
ParentViewModel extends AnyViewModel | null = null,
79
> extends ViewModel<Params, ParentViewModel> {
810
pathParams: Params;
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
import { PageViewModel } from './page-view-model';
22

33
export type AnyPageViewModel = PageViewModel<any, any>;
4+
5+
export type AnyPathParams = Partial<Record<string, string | undefined>>;

0 commit comments

Comments
 (0)