Skip to content

Commit 7cb3256

Browse files
committed
BREAKING: use mobx-view-model package; BREAKING: rename PageViewModelImpl -> PageViewModelBase (deprecation)
1 parent 913b2a7 commit 7cb3256

13 files changed

+58
-51
lines changed

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,16 @@ _**MobX** integration with **Wouter**_
2020

2121
## What package has
2222

23-
### [`PageViewModelImpl`](src/page-view-model/page-view-model.impl.ts), [`PageViewModel`](src/page-view-model/page-view-model.ts)
23+
### [`PageViewModelBase`](src/page-view-model/page-view-model.base.ts), [`PageViewModel`](src/page-view-model/page-view-model.ts)
2424

25-
Simple [`ViewModel`](https://github.com/js2me/mobx-vm-entities?tab=readme-ov-file#mobx-view-model) wrapper for pages
25+
Simple [`ViewModel`](https://github.com/js2me/mobx-view-model?tab=readme-ov-file#mobx-view-model) wrapper for pages
2626

2727
#### Usage:
2828

2929
```ts
30-
import { PageViewModelImpl } from 'mobx-wouter';
30+
import { PageViewModelBase } from 'mobx-wouter';
3131

32-
class HomePageVM extends PageViewModelImpl<{ pathParam: string }> {
32+
class HomePageVM extends PageViewModelBase<{ pathParam: string }> {
3333
@observable
3434
accessor value = 'value';
3535

@@ -49,7 +49,7 @@ HOC for integration `PageViewModel` with view component of **React**
4949
#### Usage:
5050

5151
```tsx
52-
import { ViewModelProps } from 'mobx-vm-entities';
52+
import { ViewModelProps } from 'mobx-view-model';
5353
import { withPageViewModel } from 'mobx-wouter';
5454

5555
const HomePageView = observer(({ model }: ViewModelProps<HomePageVM>) => {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"peerDependencies": {
4343
"mobx": "^6.12.4",
4444
"mobx-react-lite": "^4.0.7",
45-
"mobx-vm-entities": "^5.1.4",
45+
"mobx-view-model": "^5.2.5",
4646
"react": "^18.3.1",
4747
"wouter": "^3.3.5"
4848
},

pnpm-lock.yaml

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/hoc/with-lazy-page-view-model.test.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { act, render, screen } from '@testing-library/react';
2-
import { createCounter } from 'mobx-vm-entities/utils/counter';
2+
import { createCounter } from 'mobx-view-model/utils/counter';
33
import { describe, expect, test } from 'vitest';
44

5-
import { PageViewModelMock } from '../page-view-model/page-view-model.impl.test';
5+
import { PageViewModelBaseMock } from '../page-view-model/page-view-model.base.test';
66

77
import { withLazyPageViewModel } from './with-lazy-page-view-model';
88
import { PageViewModelProps } from './with-page-view-model';
@@ -14,7 +14,7 @@ const createIdGenerator = (prefix?: string) => {
1414

1515
describe('withLazyPageViewModel', () => {
1616
test('renders (required path param)', async () => {
17-
class VM extends PageViewModelMock<{ foo: string }> {
17+
class VM extends PageViewModelBaseMock<{ foo: string }> {
1818
mount() {
1919
super.mount();
2020
}
@@ -38,7 +38,7 @@ describe('withLazyPageViewModel', () => {
3838
expect(screen.getByText('hello VM_0')).toBeDefined();
3939
});
4040
test('renders (optional path param)', async () => {
41-
class VM extends PageViewModelMock<{ foo?: string }> {
41+
class VM extends PageViewModelBaseMock<{ foo?: string }> {
4242
mount() {
4343
super.mount();
4444
}
@@ -62,7 +62,7 @@ describe('withLazyPageViewModel', () => {
6262
expect(screen.getByText('hello VM_0')).toBeDefined();
6363
});
6464
test('renders (no path params)', async () => {
65-
class VM extends PageViewModelMock {
65+
class VM extends PageViewModelBaseMock {
6666
mount() {
6767
super.mount();
6868
}

src/hoc/with-lazy-page-view-model.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import {
22
LazyViewAndModel,
33
ViewModelHocConfig,
44
withLazyViewModel,
5-
} from 'mobx-vm-entities';
6-
import { LoadableMixin } from 'mobx-vm-entities/lib/react-simple-loadable';
5+
} from 'mobx-view-model';
6+
import { LoadableMixin } from 'mobx-view-model/lib/react-simple-loadable';
77
import { ComponentProps, ComponentType } from 'react';
88

99
import { AnyPageViewModel, PageViewModel } from '../page-view-model';

src/hoc/with-page-view-model.test.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { act, render, screen } from '@testing-library/react';
2-
import { createCounter } from 'mobx-vm-entities/utils/counter';
2+
import { createCounter } from 'mobx-view-model/utils/counter';
33
import { describe, expect, test } from 'vitest';
44

5-
import { PageViewModelMock } from '../page-view-model/page-view-model.impl.test';
5+
import { PageViewModelBaseMock } from '../page-view-model/page-view-model.base.test';
66

77
import { PageViewModelProps, withPageViewModel } from './with-page-view-model';
88

@@ -13,7 +13,7 @@ const createIdGenerator = (prefix?: string) => {
1313

1414
describe('withPageViewModel', () => {
1515
test('renders (required path param)', async () => {
16-
class VM extends PageViewModelMock<{ foo: string }> {
16+
class VM extends PageViewModelBaseMock<{ foo: string }> {
1717
mount() {
1818
super.mount();
1919
}
@@ -29,7 +29,7 @@ describe('withPageViewModel', () => {
2929
expect(screen.getByText('hello VM_0')).toBeDefined();
3030
});
3131
test('renders (optional path param)', async () => {
32-
class VM extends PageViewModelMock<{ foo?: string }> {
32+
class VM extends PageViewModelBaseMock<{ foo?: string }> {
3333
mount() {
3434
super.mount();
3535
}
@@ -45,7 +45,7 @@ describe('withPageViewModel', () => {
4545
expect(screen.getByText('hello VM_0')).toBeDefined();
4646
});
4747
test('renders (no path params)', async () => {
48-
class VM extends PageViewModelMock {
48+
class VM extends PageViewModelBaseMock {
4949
mount() {
5050
super.mount();
5151
}

src/hoc/with-page-view-model.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import {
44
ViewModelInputProps,
55
ViewModelProps,
66
withViewModel,
7-
} from 'mobx-vm-entities';
8-
import { AnyObject, Class, RenameKey } from 'mobx-vm-entities/utils/types';
7+
} from 'mobx-view-model';
8+
import { AnyObject, Class, RenameKey } from 'mobx-view-model/utils/types';
99
import { ComponentType, ReactNode } from 'react';
1010

1111
import type { AnyPageViewModel } from '../page-view-model';

src/page-view-model/index.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
import { PageViewModelBase } from './page-view-model.base';
2+
13
export * from './page-view-model';
2-
export * from './page-view-model.impl';
4+
export * from './page-view-model.base';
35
export * from './page-view-model.types';
6+
7+
/**
8+
* @deprecated Will be removed in 2.0.0 releases. Please use {@link PageViewModelBase} instead
9+
*/
10+
export const PageViewModelImpl = PageViewModelBase;
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
import { AnyViewModel } from 'mobx-view-model';
2+
import { EmptyObject } from 'mobx-view-model/utils/types';
3+
import { describe, expect, test } from 'vitest';
4+
5+
import { PageViewModelBase } from './page-view-model.base';
6+
import { AnyPathParams } from './page-view-model.types';
7+
8+
export class PageViewModelBaseMock<
9+
Params extends AnyPathParams = EmptyObject,
10+
ParentViewModel extends AnyViewModel | null = null,
11+
> extends PageViewModelBase<Params, ParentViewModel> {}
12+
13+
describe.skip('PageViewModelBase', () => {
14+
test.skip('renders', () => {
15+
expect(true).toBe(true);
16+
});
17+
});

src/page-view-model/page-view-model.impl.ts renamed to src/page-view-model/page-view-model.base.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
import { AnyViewModel, ViewModelImpl } from 'mobx-vm-entities';
2-
import { EmptyObject } from 'mobx-vm-entities/utils/types';
1+
import { AnyViewModel, ViewModelBase } from 'mobx-view-model';
2+
import { EmptyObject } from 'mobx-view-model/utils/types';
33

44
import { PageViewModel } from './page-view-model';
55
import { AnyPathParams } from './page-view-model.types';
66

7-
export class PageViewModelImpl<
7+
export class PageViewModelBase<
88
Params extends AnyPathParams = EmptyObject,
99
ParentViewModel extends AnyViewModel | null = null,
1010
>
11-
extends ViewModelImpl<Params, ParentViewModel>
11+
extends ViewModelBase<Params, ParentViewModel>
1212
implements PageViewModel<Params, ParentViewModel>
1313
{
1414
get pathParams() {

0 commit comments

Comments
 (0)