Removed JAVA bindings. Updated Python support.

Author: jscott3201

.github/workflows/ci.yml

@@ -323,16 +323,11 @@ jobs:
   github-release:
     name: GitHub Release
     if: startsWith(github.ref, 'refs/tags/v')
-    needs: [publish-crates, publish-pypi, publish-npm, publish-java, build-cli-binaries]
+    needs: [publish-crates, publish-pypi, publish-npm, build-cli-binaries]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
 
-      - uses: actions/download-artifact@v4
-        with:
-          name: java-jar
-          path: dist/java
-
       - uses: actions/download-artifact@v4
         with:
           pattern: cli-*
@@ -343,7 +338,6 @@ jobs:
         with:
           generate_release_notes: true
           files: |
-            dist/java/*.jar
             dist/cli/bacnet-*
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -414,136 +408,6 @@ jobs:
           name: cli-${{ matrix.target }}
           path: ${{ matrix.binary }}
 
-  # ===========================================================================
-  # Tier 2b — Java/Kotlin release
-  # ===========================================================================
-
-  build-java-native:
-    name: Java Native (${{ matrix.os }} ${{ matrix.target }})
-    if: startsWith(github.ref, 'refs/tags/v')
-    needs: validate
-    runs-on: ${{ matrix.os }}
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-          - os: ubuntu-latest
-            target: x86_64-unknown-linux-gnu
-            jna_dir: linux-x86-64
-            lib_name: libbacnet_java.so
-            features: "--features bacnet-transport/ipv6,bacnet-transport/sc-tls,bacnet-transport/serial,bacnet-transport/ethernet"
-          - os: ubuntu-24.04-arm
-            target: aarch64-unknown-linux-gnu
-            jna_dir: linux-aarch64
-            lib_name: libbacnet_java.so
-            features: "--features bacnet-transport/ipv6,bacnet-transport/sc-tls,bacnet-transport/serial,bacnet-transport/ethernet"
-          - os: macos-latest
-            target: x86_64-apple-darwin
-            jna_dir: darwin-x86-64
-            lib_name: libbacnet_java.dylib
-            features: "--features bacnet-transport/ipv6,bacnet-transport/sc-tls"
-          - os: macos-latest
-            target: aarch64-apple-darwin
-            jna_dir: darwin-aarch64
-            lib_name: libbacnet_java.dylib
-            features: "--features bacnet-transport/ipv6,bacnet-transport/sc-tls"
-          - os: windows-latest
-            target: x86_64-pc-windows-msvc
-            jna_dir: win32-x86-64
-            lib_name: bacnet_java.dll
-            features: "--features bacnet-transport/ipv6,bacnet-transport/sc-tls"
-    steps:
-      - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@master
-        with:
-          toolchain: "1.93"
-          targets: ${{ matrix.target }}
-      - uses: Swatinem/rust-cache@v2
-        with:
-          key: java-${{ matrix.target }}
-
-      - name: Install Linux aarch64 dependencies
-        if: matrix.target == 'aarch64-unknown-linux-gnu' && runner.arch != 'ARM64'
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y gcc-aarch64-linux-gnu
-
-      - name: Build native library
-        run: cargo build -p bacnet-java --release --target ${{ matrix.target }} ${{ matrix.features }}
-
-      - name: Upload native library
-        uses: actions/upload-artifact@v4
-        with:
-          name: java-native-${{ matrix.jna_dir }}
-          path: target/${{ matrix.target }}/release/${{ matrix.lib_name }}
-
-  publish-java:
-    name: Publish Java/Kotlin JAR
-    if: startsWith(github.ref, 'refs/tags/v')
-    needs: [build-java-native]
-    runs-on: ubuntu-latest
-    permissions:
-      packages: write
-      contents: read
-    steps:
-      - uses: actions/checkout@v4
-
-      - uses: dtolnay/rust-toolchain@master
-        with:
-          toolchain: "1.93"
-      - uses: Swatinem/rust-cache@v2
-
-      - uses: actions/setup-java@v4
-        with:
-          distribution: temurin
-          java-version: "21"
-
-      - name: Download all native libraries
-        uses: actions/download-artifact@v4
-        with:
-          pattern: java-native-*
-          path: native-libs
-
-      - name: Build Linux x86_64 cdylib for binding generation
-        run: cargo build -p bacnet-java --release
-
-      - name: Build uniffi-bindgen
-        run: cargo build -p uniffi-bindgen
-
-      - name: Generate Kotlin bindings
-        run: |
-          cargo run -p uniffi-bindgen -- generate \
-            --library target/release/libbacnet_java.so \
-            --language kotlin \
-            --no-format \
-            --out-dir java/src/main/kotlin
-
-      - name: Assemble native libraries into JNA layout
-        run: |
-          for dir in native-libs/java-native-*/; do
-            JNA_DIR=$(basename "$dir" | sed 's/java-native-//')
-            mkdir -p "java/src/main/resources/$JNA_DIR"
-            cp "$dir"/* "java/src/main/resources/$JNA_DIR/"
-          done
-          find java/src/main/resources -type f | sort
-
-      - name: Build JAR
-        working-directory: java
-        run: ./gradlew build
-
-      - name: Publish to GitHub Packages
-        working-directory: java
-        run: ./gradlew publish
-        env:
-          GITHUB_ACTOR: ${{ github.actor }}
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Upload JAR artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: java-jar
-          path: java/build/libs/*.jar
-
   # ===========================================================================
   # Docker Hub (placeholder for 1.0)
   # ===========================================================================

.gitignore

@@ -48,16 +48,6 @@ Thumbs.db
 *.swo
 *~
 
-# Java/Gradle
-java/.gradle/
-java/build/
-java/benchmarks/.gradle/
-java/benchmarks/build/
-java/src/main/kotlin/uniffi/
-java/src/main/resources/darwin-*/
-java/src/main/resources/linux-*/
-java/src/main/resources/win32-*/
-
 # JavaScript/WASM
 node_modules/
 pkg/

Benchmarks.md

@@ -1,6 +1,6 @@
 # Rusty BACnet — Benchmarks & Stress Test Results
 
-> Last full run: 2026-03-05 | Platform: macOS (Apple Silicon) | Rust 1.93 | JDK 21.0.10 | Release mode
+> Last full run: 2026-03-05 | Platform: macOS (Apple Silicon) | Rust 1.93 | Release mode
 >
 > TLS provider: aws-lc-rs | All tests ran on localhost with zero errors unless noted.
 >
@@ -228,14 +228,6 @@ Peak RSS: 9.2 MB. Scan time scales linearly.
 SC mTLS adds negligible overhead vs server-auth-only SC — the TLS handshake dominates, not per-message client cert verification.
 Python concurrent throughput is competitive with Rust single-threaded due to tokio's multi-threaded runtime handling the actual I/O.
 
-### Kotlin/JVM (UniFFI/JNA, coroutines)
-
-| Transport | RP Latency | Sequential Throughput | Overhead vs Rust |
-|---|---|---|---|
-| **BIP (Kt→Rust)** | ~74 µs | 14.0 K/s | +2.7× latency |
-
-Kotlin/JNA overhead (~46 µs) is ~40% lower than Python/PyO3 (~80 µs) per async call.
-
 ---
 
 ## 4. Docker Cross-Network Tests
@@ -441,81 +433,12 @@ comparable to pure Rust's single-threaded 36K/s.
 
 ---
 
-## 7. Kotlin/JVM ↔ Rust Benchmarks (UniFFI/JNA)
-
-> JDK 21.0.10 (OpenJDK, Apple Silicon) | UniFFI 0.29 + JNA 5.15 | JMH 1.37 | kotlinx-coroutines 1.9.0
->
-> All tests use the `bacnet-java` UniFFI bindings on localhost over BIP (UDP/IPv4).
-> Server hosts 15 mixed objects (analog-input/output, binary-value, multistate-input).
-
-### 7.1 BACnet/IP — Kotlin Client → Rust Server
-
-| Operation | Mean | ± Error |
-|---|---|---|
-| ReadProperty | **73.9 µs** | ± 1.1 µs |
-| WriteProperty | **80.6 µs** | ± 5.7 µs |
-| RPM (3×2 props) | **78.1 µs** | ± 0.7 µs |
-| COV Sub/Unsub | **132.8 µs** | ± 2.8 µs |
-| WhoIs | **30.7 µs** | ± 3.5 µs |
-
-Sequential throughput: **~14,000 ops/s** (ReadProperty)
-
-### 7.2 Concurrency Scaling
-
-| Coroutines | Throughput | Per-coroutine |
-|---|---|---|
-| 1 | **13,258 ops/s** | 13,258 /s |
-| 5 | 4,534 ops/s | 907 /s |
-| 10 | 2,636 ops/s | 264 /s |
-| 25 | 1,116 ops/s | 45 /s |
-
-Note: JMH measures one benchmark iteration at a time. Each iteration launches N coroutines
-that each do a full ReadProperty round-trip. The throughput decrease at higher concurrency
-reflects the cost of N sequential round-trips per iteration, not a server bottleneck.
-
-### 7.3 JNA/FFI Overhead
-
-| Operation | Mean | ± Error |
-|---|---|---|
-| ObjectIdentifier (create) | **10.9 µs** | ± 9.7 µs |
-| ObjectIdentifier (display) | **14.9 µs** | ± 5.7 µs |
-| PropertyValue (Real) | **3.2 ns** | ± 0.6 ns |
-| PropertyValue (String) | **3.1 ns** | ± 0.05 ns |
-| PropertyValue (Unsigned) | **4.1 ns** | ± 0.04 ns |
-
-Simple Kotlin enum construction (PropertyValue variants) is **~3 ns** — pure JVM allocation.
-ObjectIdentifier creation crosses the JNA FFI boundary at **~11 µs** per call (higher variance
-due to JNA native library loading and GC interaction).
-
-### 7.4 Object Creation
-
-| Operation | Mean | ± Error |
-|---|---|---|
-| Add AnalogInput | **39.0 µs** | ± 13.1 µs |
-| Add 5 mixed objects | **190.4 µs** | ± 72.4 µs |
-
-Server object creation includes FFI crossing + Rust object construction + database insertion.
-
-### 7.5 Kotlin API Overhead Analysis
-
-| Transport | Rust Latency | Kotlin Latency | Overhead |
-|---|---|---|---|
-| BIP ReadProperty | 27.5 µs | ~74 µs | ~46 µs (+2.7×) |
-| BIP WriteProperty | 28.7 µs | ~81 µs | ~52 µs (+2.8×) |
-| BIP RPM (3×2) | 32.0 µs | ~78 µs | ~46 µs (+2.4×) |
-
-Kotlin/JNA overhead is **~46–52 µs** per async round-trip, lower than Python's ~80 µs.
-The overhead comes from: UniFFI async dispatch (~10 µs), JNA FFI boundary (~11 µs per crossing),
-and Kotlin coroutine suspension/resumption (~25 µs).
-
----
-
-## 8. Key Takeaways
+## 7. Key Takeaways
 
 - **Encoding is fast**: Full RP encode/decode stack in ~131 ns (CPU-bound, no allocation hot paths thanks to `Bytes` zero-copy)
 - **BIP throughput scales linearly**: 40K/s single-client → 161K/s at 50 clients with sub-millisecond p99
 - **Concurrent dispatch unlocks RwLock parallelism**: Server now spawns per-request tasks — multiple ReadProperty requests run truly concurrently via `db.read()`. Quick benchmarks show ~44% read throughput improvement (full run pending)
-- **Multi-device batch API**: Client `read_property_from_devices()` / `read_property_multiple_from_devices()` / `write_property_to_devices()` fan out to N devices concurrently with configurable `max_concurrent` (default 32). Available in Rust, Python, and Java/Kotlin
+- **Multi-device batch API**: Client `read_property_from_devices()` / `read_property_multiple_from_devices()` / `write_property_to_devices()` fan out to N devices concurrently with configurable `max_concurrent` (default 32). Available in Rust and Python
 - **Object count doesn't matter**: 100 → 5,000 objects shows zero latency degradation (RwLock contention minimal)
 - **COV is reliable**: 100% notification delivery at 25 concurrent subscriptions
 - **SC overhead is ~2.5×**: TLS WebSocket adds ~40 µs per operation vs raw UDP — acceptable for secure deployments
@@ -525,8 +448,6 @@ and Kotlin coroutine suspension/resumption (~25 µs).
 - **Musl/Alpine parity**: Docker (static musl) matches native performance — no penalty for containerized deployment
 - **Python API is production-ready**: ~80 µs PyO3 overhead per call; 36K concurrent ops/s from Python matches pure Rust throughput
 - **SC from Python works**: ScHub + SC client/server all work via PyO3; 29K ops/s at 25 concurrent clients
-- **Kotlin/JNA is faster than Python**: ~46 µs UniFFI overhead per async call vs Python's ~80 µs; 14K sequential ops/s
-- **JNA primitive overhead is negligible**: PropertyValue enum construction is ~3 ns (pure JVM); ObjectIdentifier FFI crossing ~11 µs
 
 ---
 
@@ -566,10 +487,4 @@ uv run pytest bench_py_client_rust_server.py -v   # BIP: Py client → Rust serv
 uv run pytest bench_rust_client_py_server.py -v   # BIP: Rust client → Py server
 uv run pytest bench_py_py.py -v                   # BIP: Py ↔ Py
 uv run pytest bench_sc.py -v                      # SC: Py client → Rust server via ScHub
-
-# Kotlin/JVM JMH benchmarks (requires JDK 21+)
-cd java
-./build-local.sh --release                        # Build native lib + Kotlin bindings + JAR
-./gradlew :benchmarks:jmh                         # Full benchmark suite (~10 min)
-# Results: java/benchmarks/build/reports/jmh/results.json
 ```

CHANGELOG.md

@@ -113,6 +113,69 @@ Deep-dive review of all five transport implementations (BIP, BIPv6, BACnet/SC, E
 - **Added** named `NPDU_CHANNEL_CAPACITY` constants in all transports (256 for BIP/BIP6/Ethernet/Loopback, 64 for SC/MS/TP) with documented rationale
 - **Changed** `bip6` module feature-gated behind `ipv6` feature flag — consistent with `ethernet` and `sc-tls` gating; propagated to bacnet-client, bacnet-java, bacnet-btl, bacnet-cli, benchmarks
 
+### Spec Compliance — Stack-Wide (ASHRAE 135-2020 Clauses 5, 6, 12, 13, 15, 16, 20)
+
+Deep-dive review of encoding, types, services, objects, client, server, and network layers identified 43 spec compliance issues. All critical/high/medium fixed.
+
+#### Encoding & APDU (Clause 20)
+- **Fixed** SegmentAck window size not clamped to 1-127 range on decode — now clamps with warning log per Clause 20.1.6
+- **Fixed** reserved max_apdu values silently accepted — now logs warning for non-standard values
+
+#### Types & Enums (Clause 21)
+- **Fixed** LifeSafetyOperation enum ordering — reset=4, reset-alarm=5, reset-fault=6, unsilence=7 per Table 12-54
+- **Added** LifeSafetyMode OEO values (15-19) per 135-2020 addendum
+- **Added** DaysOfWeek bitflags type for schedule encoding
+- **Added** 11 new BACnetPropertyStates variants (UnsignedValue, DoorAlarmState, Action, DoorSecuredStatus, DoorStatus, DoorValue, TimerState, TimerTransition, LiftCarDirection, LiftCarDoorCommand)
+
+#### Services (Clauses 13-16)
+- **Fixed** TextMessage tags — messagePriority and message use context tags [2] and [3] (were [3] and [4])
+- **Fixed** ReinitializeDevice password validation — SIZE(1..20) per Clause 16.4.1.1.5
+- **Added** `message_text: Option<String>` field to EventNotificationRequest with encode/decode per Clause 13.8.1
+- **Added** `RecipientProcess` struct and `enrollment_filter` field to GetEnrollmentSummaryRequest
+
+#### Objects (Clause 12)
+- **Fixed** StatusFlags IN_ALARM never set — all 9 event-capable object types (AI/AO/AV/BI/BO/BV/MSI/MSO/MSV) now compute IN_ALARM from `event_detector.event_state`
+- **Added** `compute_status_flags()` helper function for consistent StatusFlags computation across object types
+- **Added** ValueSourceTracking fields (VALUE_SOURCE, LAST_COMMAND_TIME) to AV, BO, BV, MSO, MSV
+- **Added** `set_overridden()` default method on BACnetObject trait
+
+#### Client (Clause 5.4)
+- **Fixed** per-window SegmentAck — tracks window position for correct sequence acknowledgment
+- **Fixed** duplicate segment handling in segmented response reassembly
+- **Fixed** negative SegmentAck uses `wrapping_sub(1)` for correct sequence arithmetic
+- **Added** Abort on unsupported segmented response when `segmented_response_accepted` is false
+- **Added** `segmented_response_accepted` parameter threading through dispatch_apdu/handle_segmented_complex_ack
+- **Added** device table auto-purge every 5 minutes for stale entries
+
+#### Server
+- **Fixed** COV notification `ack_required` flag — `notify_type == NotifyType::ALARM` (was `!= ACK_NOTIFICATION`)
+- **Fixed** DCC DISABLE now accepted — all 3 EnableDisable values work correctly per 135-2020
+- **Fixed** COVProperty cancel now calls `unsubscribe_property()` instead of `unsubscribe()`
+- **Fixed** RPM handler resolves device wildcard via `resolve_device_wildcard()`
+- **Fixed** GetEnrollmentSummary priority lookup reads from notification class object (was hardcoded 0)
+- **Fixed** intrinsic reporting silently non-functional — EVENT_ENABLE stored as BitString but read via `read_unsigned()`; added `read_event_enable()` helper handling both types
+- **Fixed** schedule tick passes UTC offset parameter for correct time computation
+- **Fixed** EventNotificationRequest now includes `message_text: None` field
+- **Added** `days_to_date()` helper for full datetime in trend log records
+
+#### Network (Clause 6)
+- **Fixed** remote broadcast self-delivery — router now delivers broadcast to local network layer
+- **Fixed** `is_network_message` passthrough in routing (was hardcoded false)
+- **Fixed** proprietary network messages (type >= 0x80) with DNET now forwarded correctly
+- **Fixed** Init-Routing-Table-Ack uses actual port_index (was hardcoded)
+
+### Python Bindings Improvements
+
+- **Rewritten** `.pyi` type stubs from scratch (826 → 1598 lines) — all 47 client methods, 62+ server methods, correct exception names, CovNotification class, PropertyValue constructors, all 65 ObjectType constants
+- **Added** `time_synchronization()` and `utc_time_synchronization()` methods
+- **Added** `who_is_directed()` for unicast WhoIs
+- **Added** auto-routing methods: `read_property_from_device()`, `read_property_multiple_from_device()`, `write_property_to_device()`, `write_property_multiple_to_device()`
+- **Added** `add_device()` for manual device table population
+- **Added** `discover(timeout_ms)` convenience method — combines WhoIs + sleep + discovered_devices
+- **Added** `PropertyValue.date()`, `.time()`, `.bit_string()`, `.list()` static constructors
+- **Added** structured error attributes — `BacnetProtocolError.error_class`/`.error_code`, `BacnetRejectError.reason`, `BacnetAbortError.reason`
+- **Added** `dcc_password` and `reinit_password` parameters to `BACnetServer` constructor
+
 ### Added
 - **New crate: `bacnet-gateway`** — HTTP REST API and MCP (Model Context Protocol) server for BACnet networks
   - REST API at `/api/v1/` with endpoints for device discovery, property read/write, local object CRUD, and health check
@@ -125,14 +188,15 @@ Deep-dive review of all five transport implementations (BIP, BIPv6, BACnet/SC, E
 - **Client batch operations** — `read_property_from_devices()`, `read_property_multiple_from_devices()`, `write_property_to_devices()` with `buffer_unordered(max_concurrent)` for concurrent multi-device I/O
 - **Client auto-routing** — `resolve_device()` helper + `_from_device` variants for RP, RPM, WP, WPM
 - **Server concurrent dispatch** — spawns per-request tasks for ConfirmedRequest/UnconfirmedRequest, enabling concurrent `db.read()` from multiple clients
-- **Python bindings** — batch methods (`read_property_from_devices`, etc.) and COV async iterator improvements
-- **Java/Kotlin bindings** — batch methods and `CovNotificationStream` improvements
 - **Architecture documentation** — `docs/architecture.md`, expanded `docs/rust-api.md`, `docs/gateway.md`, `docs/btl.md`, `docs/wasm-api.md`
 
 ### Changed
 - **Dependencies updated** — criterion 0.5→0.8, tokio-tungstenite 0.28→0.29, rand 0.9→0.10, rustyline 15→17, toml 0.8→1.0, rcgen 0.13→0.14, aws-lc-sys 0.38→0.39, rustls-webpki 0.103.9→0.103.10
 - **Security advisories resolved** — aws-lc-sys X.509 name constraints bypass, CRL distribution point logic errors; rustls-webpki CRL scope check
 
+### Removed
+- **Java/Kotlin bindings** — removed `bacnet-java` crate, `uniffi-bindgen` crate, `java/` Gradle project, `examples/kotlin/`, and all associated CI jobs (no user base; maintenance burden)
+
 ## [0.7.2]
 
 ### Added