checkRedundantReturns: dropped return type checking

Alexej Yaroshevich · Alexej Yaroshevich · commit 7f7b6e4cc3c7 · 2015-01-25T17:36:43.000+04:00
Ref #82
diff --git a/lib/rules/validate-jsdoc/check-redundant-returns.js b/lib/rules/validate-jsdoc/check-redundant-returns.js
@@ -18,9 +18,9 @@ function checkReturnTypes(node, tag, err) {
     }
 
     // checking redundant: invalid or not return statements in code
-    var redundant = !tag.type.valid || !this._getReturnStatementsForNode(node).length;
+    var redundant = !Boolean(this._getReturnStatementsForNode(node).length);
 
     if (redundant) {
-        err('redundant returns statement');
+        err('Redundant return statement', tag.loc);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -18,9 +18,9 @@ function checkReturnTypes(node, tag, err) {`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`// checking redundant: invalid or not return statements in code`
`21`		`- var redundant = !tag.type.valid \|\| !this._getReturnStatementsForNode(node).length;`
	`21`	`+ var redundant = !Boolean(this._getReturnStatementsForNode(node).length);`
`22`	`22`
`23`	`23`	`if (redundant) {`
`24`		`- err('redundant returns statement');`
	`24`	`+ err('Redundant return statement', tag.loc);`
`25`	`25`	`}`
`26`	`26`	`}`