Merge pull request #40 from zxqfox/hotfix/param-name-throw

fix param name throws

Author: qfox

lib/rules/validate-jsdoc/check-param-names.js

@@ -21,13 +21,17 @@ function validateCheckParamNames(node, err) {
          * @param {Number} i index
          */
         function(tag, i) {
-            var param = node.params[i];
-
             // checking validity
             if (!tag.name) {
                 return err('missing param name', tag.loc);
             }
 
+            var param = node.params[i];
+            if (!param) {
+                // skip if no param
+                return;
+            }
+
             // checking name
             if (tag.name.value !== param.name) {
                 return err('expected ' + param.name + ' but got ' + tag.name.value,

test/lib/rules/validate-jsdoc/check-param-names.js

@@ -13,6 +13,13 @@ describe('rules/validate-jsdoc', function () {
                 code: function() {
                     function yay(yey) {
                     }
+
+                    /**
+                     * @param {number} yay
+                     * @param {string} bar this shouldn't throw
+                     */
+                    function yey(yay) {
+                    }
                 }
 
             }, {

test/lib/rules/validate-jsdoc/check-redundant-access.js

@@ -9,6 +9,13 @@ describe('rules/validate-jsdoc', function () {
         checker.cases([
             /* jshint ignore:start */
             {
+                it: 'should not throw',
+                code: function() {
+                    function yay(yey) {
+                    }
+                }
+
+            }, {
                 it: 'should report confusing multiaccess',
                 errors: 1,
                 code: function () {

test/lib/rules/validate-jsdoc/check-redundant-returns.js

@@ -9,6 +9,13 @@ describe('rules/validate-jsdoc', function () {
         checker.cases([
             /* jshint ignore:start */
             {
+                it: 'should not throw',
+                code: function() {
+                    function yay(yey) {
+                    }
+                }
+
+            }, {
                 it: 'should report redundant @returns for function',
                 errors: 3,
                 code: function () {

test/lib/rules/validate-jsdoc/check-return-types.js

@@ -9,6 +9,13 @@ describe('rules/validate-jsdoc', function () {
         checker.cases([
             /* jshint ignore:start */
             {
+                it: 'should not throw',
+                code: function() {
+                    function yay(yey) {
+                    }
+                }
+
+            }, {
                 it: 'should throw invalid type',
                 errors: 1,
                 code: function () {

test/lib/rules/validate-jsdoc/check-types.js

@@ -9,6 +9,13 @@ describe('rules/validate-jsdoc', function() {
         checker.cases([
             /* jshint ignore:start */
             {
+                it: 'should not throw',
+                code: function() {
+                    function yay(yey) {
+                    }
+                }
+
+            }, {
                 it: 'should report invalid typedef',
                 errors: 1,
                 code: function() {

test/lib/rules/validate-jsdoc/leading-underscore-access.js

@@ -8,6 +8,13 @@ describe('rules/validate-jsdoc', function () {
         checker.cases([
             /* jshint ignore:start */
             {
+                it: 'should not throw',
+                code: function() {
+                    function yay(yey) {
+                    }
+                }
+
+            }, {
                 it: 'should report enforcing @private on leading underscores',
                 rules: {leadingUnderscoreAccess: 'private'},
                 errors: 1,

test/lib/rules/validate-jsdoc/require-param-types.js

@@ -9,6 +9,13 @@ describe('rules/validate-jsdoc', function () {
         checker.cases([
             /* jshint ignore:start */
             {
+                it: 'should not throw',
+                code: function() {
+                    function yay(yey) {
+                    }
+                }
+
+            }, {
                 it: 'should report missing jsdoc-param type for function',
                 errors: 1,
                 code: function () {

test/lib/rules/validate-jsdoc/require-return-types.js

@@ -9,6 +9,13 @@ describe('rules/validate-jsdoc', function () {
         checker.cases([
             /* jshint ignore:start */
             {
+                it: 'should not throw',
+                code: function() {
+                    function yay(yey) {
+                    }
+                }
+
+            }, {
                 it: 'should report invalid @returns',
                 errors: 1,
                 code: function() {