Skip to content
This repository was archived by the owner on Mar 23, 2024. It is now read-only.

Commit c2c4d5d

Browse files
committed
[Perf] Remove getNodeByRange
1 parent c2f6112 commit c2c4d5d

File tree

2 files changed

+0
-62
lines changed

2 files changed

+0
-62
lines changed

lib/js-file.js

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -295,25 +295,6 @@ JsFile.prototype = {
295295
return treeIterator.iterate(tree || this._program, cb);
296296
},
297297

298-
/**
299-
* Returns node by its range position
300-
*
301-
* @returns {Object}
302-
*/
303-
getNodeByRange: function(number) {
304-
var result = {};
305-
306-
this.iterate(function(node) {
307-
if (number >= node.getRange()[0] && number < node.getRange()[1]) {
308-
result = node;
309-
}
310-
if (number < node.getRange()[0]) {
311-
return false;
312-
}
313-
});
314-
return result;
315-
},
316-
317298
/**
318299
* Returns nodes by type(s) from earlier built index.
319300
*

test/specs/js-file.js

Lines changed: 0 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -60,49 +60,6 @@ describe('js-file', function() {
6060
});
6161
});
6262

63-
describe('getNodeByRange', function() {
64-
it('should get node by range for function declaration', function() {
65-
expect(createJsFile('function foo(a,b) {}').getNodeByRange(16).type).to.equal('FunctionDeclaration');
66-
});
67-
68-
it('should get node by range for identifier', function() {
69-
expect(createJsFile('foo(a,b)').getNodeByRange(0).type).to.equal('Identifier');
70-
});
71-
72-
it('should get node by range for function expression', function() {
73-
expect(createJsFile('foo(a,b)').getNodeByRange(7).type).to.equal('CallExpression');
74-
});
75-
76-
it('should get node by range for "if" statement', function() {
77-
expect(createJsFile('if(true){foo(a,b)}').getNodeByRange(0).type).to.equal('IfStatement');
78-
});
79-
80-
it('should get node by range for identifier inside "if" statement', function() {
81-
expect(createJsFile('if(true){foo(a,b)}').getNodeByRange(9).type).to.equal('Identifier');
82-
});
83-
84-
it('should get node by range for function expression inside "if" statement', function() {
85-
expect(createJsFile('if(true){foo(a,b)}').getNodeByRange(16).type).to.equal('CallExpression');
86-
});
87-
88-
it('should get node by range for function expression with additional parentheses', function() {
89-
expect(createJsFile('foo(1,(2))').getNodeByRange(9).type).to.equal('CallExpression');
90-
});
91-
92-
it('should return empty object', function() {
93-
expect(createJsFile('foo(1,2)').getNodeByRange(20).type).to.equal(undefined);
94-
});
95-
96-
it('should not throw on regexp', function() {
97-
var file = createJsFile('/^/');
98-
try {
99-
file.getNodeByRange(1);
100-
} catch (e) {
101-
throw new Error();
102-
}
103-
});
104-
});
105-
10663
describe('findNextToken', function() {
10764
var file;
10865

0 commit comments

Comments
 (0)