Skip to content

Commit 9e52de9

Browse files
Merge pull request openshift-service-mesh#149 from openshift-service-mesh-bot/none-main-merge_upstream_main-38a843ce
Automator: merge upstream changes to openshift-service-mesh/sail-operator@main
2 parents d3b4f6a + 4124962 commit 9e52de9

File tree

9 files changed

+34
-10
lines changed

9 files changed

+34
-10
lines changed

.github/workflows/coverage.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ jobs:
1010

1111
- name: Run coverage
1212
run: |
13-
make test.unit \
13+
make test \
1414
-e COVERAGE=true
1515
1616
- name: Upload to Codecov
1717
uses: codecov/codecov-action@v4
1818
with:
19-
file: out/coverage.out
19+
files: out/coverage-unit.out,out/coverage-integration.out
2020
token: ${{ secrets.CODECOV_TOKEN }}
21-
fail_ci_if_error: true
21+
fail_ci_if_error: true

Makefile.core.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ ENVTEST_K8S_VERSION ?= 1.29.0
7171
# Set DOCKER_BUILD_FLAGS to specify flags to pass to 'docker build', default to empty. Example: --platform=linux/arm64
7272
DOCKER_BUILD_FLAGS ?= "--platform=$(TARGET_OS)/$(TARGET_ARCH)"
7373

74-
GOTEST_FLAGS := $(if $(VERBOSE),-v) $(if $(COVERAGE),-coverprofile=$(REPO_ROOT)/out/coverage.out)
75-
GINKGO_FLAGS := $(if $(VERBOSE),-v) $(if $(CI),--no-color)
74+
GOTEST_FLAGS := $(if $(VERBOSE),-v) $(if $(COVERAGE),-coverprofile=$(REPO_ROOT)/out/coverage-unit.out)
75+
GINKGO_FLAGS := $(if $(VERBOSE),-v) $(if $(CI),--no-color) $(if $(COVERAGE),-coverprofile=coverage-integration.out -coverpkg=./... --output-dir=out)
7676

7777
# CHANNELS define the bundle channels used in the bundle.
7878
# Add a new line here if you would like to change its default config. (E.g CHANNELS = "candidate,fast,stable")

api/v1alpha1/values_types.gen.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/v1alpha1/zz_generated.deepcopy.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bundle/manifests/sailoperator.io_istiocnis.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1392,6 +1392,12 @@ spec:
13921392
If empty, default scope and level will be used as configured in code
13931393
type: string
13941394
type: object
1395+
platform:
1396+
description: |-
1397+
Platform in which Istio is deployed. Possible values are: "openshift" and "gcp"
1398+
An empty value means it is a vanilla Kubernetes distribution, therefore no special
1399+
treatment will be considered.
1400+
type: string
13951401
tag:
13961402
description: Specifies the tag for the Istio docker images.
13971403
type: string

chart/crds/sailoperator.io_istiocnis.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1392,6 +1392,12 @@ spec:
13921392
If empty, default scope and level will be used as configured in code
13931393
type: string
13941394
type: object
1395+
platform:
1396+
description: |-
1397+
Platform in which Istio is deployed. Possible values are: "openshift" and "gcp"
1398+
An empty value means it is a vanilla Kubernetes distribution, therefore no special
1399+
treatment will be considered.
1400+
type: string
13951401
tag:
13961402
description: Specifies the tag for the Istio docker images.
13971403
type: string

docs/api-reference/sailoperator.io.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ _Appears in:_
139139
| `logging` _[GlobalLoggingConfig](#globalloggingconfig)_ | Specifies the global logging level settings for the Istio control plane components. | | |
140140
| `tag` _string_ | Specifies the tag for the Istio docker images. | | |
141141
| `variant` _string_ | The variant of the Istio container images to use. Options are "debug" or "distroless". Unset will use the default for the given version. | | |
142+
| `platform` _string_ | Platform in which Istio is deployed. Possible values are: "openshift" and "gcp" An empty value means it is a vanilla Kubernetes distribution, therefore no special treatment will be considered. | | |
142143

143144

144145
#### CNIRepairConfig

hack/api_transformer/transform.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ inputFiles:
129129
- ImagePullSecrets
130130
- LogAsJson
131131
- Logging
132+
- Platform
132133
- Tag
133134
- Variant
134135
addComments:

pkg/test/util/supportedversion/supportedversion_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ import (
2222

2323
func TestInit(t *testing.T) {
2424
// no need to call init(), since it's called automatically
25-
assert.True(t, len(List) > 0, "List should not be empty")
26-
assert.True(t, len(Map) > 0, "M should not be empty")
27-
assert.True(t, Default != "", "Default should not be empty")
28-
assert.True(t, Old != "", "Default should not be empty")
29-
assert.True(t, New != "", "Default should not be empty")
25+
assert.True(t, len(List) > 0, "supportedversion.List should not be empty")
26+
assert.True(t, len(Map) > 0, "supportedversion.Map should not be empty")
27+
assert.True(t, Default != "", "supportedversion.Default should not be empty")
28+
assert.True(t, Old != "", "supportedversion.Old should not be empty")
29+
assert.True(t, New != "", "supportedversion.New should not be empty")
3030

3131
assert.Equal(t, len(List), len(Map), "Map should be same size as List")
3232
for _, vi := range List {

0 commit comments

Comments
 (0)