refactor: use the declaring class to access fields in child class

Non-private static members of the parent class are accessible by child classes. However, it is a bad practice to do so, because it obscures where a value was actually declared. Always use only the declaring class to access static members.

Author: deepsource-autofix[bot]

src/main/java/org/infernus/idea/checkstyle/toolwindow/CheckStyleToolWindowPanel.java

@@ -162,14 +162,14 @@ private JPanel createToolPanel() {
         resultsTree.setCellRenderer(new ResultTreeRenderer());
 
         progressLabel = new JLabel(" ");
-        progressBar = new JProgressBar(JProgressBar.HORIZONTAL);
+        progressBar = new JProgressBar(SwingConstants.HORIZONTAL);
         progressBar.setMinimum(0);
         final Dimension progressBarSize = new Dimension(100, progressBar.getPreferredSize().height);
         progressBar.setMinimumSize(progressBarSize);
         progressBar.setPreferredSize(progressBarSize);
         progressBar.setMaximumSize(progressBarSize);
 
-        progressPanel = new JToolBar(JToolBar.HORIZONTAL);
+        progressPanel = new JToolBar(SwingConstants.HORIZONTAL);
         progressPanel.add(Box.createHorizontalStrut(4));
         progressPanel.add(new JLabel(message("plugin.toolwindow.override")));
         progressPanel.add(Box.createHorizontalStrut(4));

src/main/java/org/infernus/idea/checkstyle/ui/PropertiesPanel.java

@@ -60,7 +60,7 @@ private void initialise() {
         propertiesTable.getTableHeader().setReorderingAllowed(false);
 
         final JScrollPane propertiesScrollPane = new JBScrollPane(propertiesTable,
-                JScrollPane.VERTICAL_SCROLLBAR_ALWAYS, JScrollPane.HORIZONTAL_SCROLLBAR_ALWAYS);
+                ScrollPaneConstants.VERTICAL_SCROLLBAR_ALWAYS, ScrollPaneConstants.HORIZONTAL_SCROLLBAR_ALWAYS);
         add(propertiesScrollPane, BorderLayout.CENTER);
     }