Improve error message when req missing headers property

Author: dougwilson

HISTORY.md

@@ -2,6 +2,7 @@ unreleased
 ==========
 
   * Improve error message when `req` argument is not an object
+  * Improve error message when `req` missing `headers` property
 
 1.0.3 / 2015-07-01
 ==================

index.js

@@ -55,7 +55,7 @@ function auth(req) {
   }
 
   // get header
-  var header = (req.req || req).headers.authorization
+  var header = getAuthorization(req.req || req)
 
   // parse header
   var match = credentialsRegExp.exec(header || '')
@@ -84,6 +84,19 @@ function decodeBase64(str) {
   return new Buffer(str, 'base64').toString()
 }
 
+/**
+ * Get the Authorization header from request object.
+ * @private
+ */
+
+function getAuthorization(req) {
+  if (!req.headers || typeof req.headers !== 'object') {
+    throw new TypeError('argument req is required to have headers property')
+  }
+
+  return req.headers.authorization
+}
+
 /**
  * Object to represent user credentials.
  * @private

test/basic-auth.js

@@ -37,6 +37,10 @@ describe('auth(req)', function () {
       it('should reject a number', function () {
         assert.throws(auth.bind(null, 42), /argument req is required/)
       })
+
+      it('should reject an object without headers', function () {
+        assert.throws(auth.bind(null, {}), /argument req is required/)
+      })
     })
   })