Skip to content

ci: add nodejs v18 - v24 to test matrix #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Phillip9587
Copy link
Contributor

This pull request updates the Node.js versions tested in the CI workflow to include newer releases.

@Phillip9587 Phillip9587 requested a review from bjohansebas June 19, 2025 15:42
@Phillip9587 Phillip9587 requested a review from UlisesGascon June 24, 2025 12:45
@bjohansebas
Copy link
Member

v23 is failing

@Phillip9587
Copy link
Contributor Author

v23 is failing

Please take a look at my comment

@Phillip9587
Copy link
Contributor Author

@bjohansebas @UlisesGascon Can you take another look? I updated the test to include a isError fallback for Node 23. The CI failures are just related to Coveralls current status: https://status.coveralls.io/incidents/fr6sp5kyn128

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants